Skip to content

Revert "Add networking test for invalid external gateway"#26975

Merged
deads2k merged 1 commit intoopenshift:masterfrom
stbenjam:revert-26883-invalid-ext-gateway-test
Apr 6, 2022
Merged

Revert "Add networking test for invalid external gateway"#26975
deads2k merged 1 commit intoopenshift:masterfrom
stbenjam:revert-26883-invalid-ext-gateway-test

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Apr 6, 2022

Reverts #26883

This test does not work on e2e-metal-ipi-dualstack.

Failures:
https://prow.ci.openshift.org/view/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-ipi-ovn-dualstack/1511498122491072512
https://prow.ci.openshift.org/view/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-ipi-ovn-dualstack/1511438450115481600

To undo this revert, please invoke e2e-metal-ipi-ovn-dualstack and confirm this test passes. We don't have any run yet on e2e-metal-ipi-ovn-ipv6 but based on the way the test was written, would this work there? Is this test assuming it's only ever run on IPv4 clusters?

@openshift-ci openshift-ci bot requested review from celebdor and knobunc April 6, 2022 12:26
@stbenjam
Copy link
Member Author

stbenjam commented Apr 6, 2022

/cc pperiyasamy adambkaplan dcbw

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
@openshift-ci openshift-ci bot requested review from adambkaplan and dcbw April 6, 2022 12:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

@stbenjam: GitHub didn't allow me to request PR reviews from the following users: pperiyasamy.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc pperiyasamy adambkaplan dcbw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor

dgoodwin commented Apr 6, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2022
@stbenjam
Copy link
Member Author

stbenjam commented Apr 6, 2022

/cc @pperiyasamy

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

@stbenjam: GitHub didn't allow me to request PR reviews from the following users: pperiyasamy.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @pperiyasamy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trozet
Copy link
Contributor

trozet commented Apr 6, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, stbenjam, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor

deads2k commented Apr 6, 2022

merging to fix payloads.

@deads2k deads2k merged commit 0925668 into openshift:master Apr 6, 2022
@stbenjam stbenjam deleted the revert-26883-invalid-ext-gateway-test branch April 6, 2022 13:54
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-csi ba8377f link false /test e2e-gcp-csi
ci/prow/e2e-gcp ba8377f link true /test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pperiyasamy added a commit to pperiyasamy/origin that referenced this pull request Apr 7, 2022
…-invalid-ext-gateway-test"

This reverts commit 0925668, reversing
changes made to 36ddf05.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments