Skip to content

Comments

Bug 2070703: change networkpolicy ACLs to use "apply-after-lb" for egress#1020

Closed
JacobTanenbaum wants to merge 5 commits intoopenshift:masterfrom
JacobTanenbaum:BZ2070703
Closed

Bug 2070703: change networkpolicy ACLs to use "apply-after-lb" for egress#1020
JacobTanenbaum wants to merge 5 commits intoopenshift:masterfrom
JacobTanenbaum:BZ2070703

Conversation

@JacobTanenbaum
Copy link
Contributor

Revert the changes made to the openshift-priv repo and backport the upstream commits from PR ovn-kubernetes/ovn-kubernetes#2881

this version will fix the ipv6 tests and will ensure master is closer to upstream.

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

This reverts commit 6780c89, reversing
changes made to 50f9cb6.
Currently all network policy ACLs are placed on the OVN ingress
pipeline. Since the first ACL of the highest priority is action is
followed there is no way to ensure the correct operation of network
policies when multiple apply to the same pod.

Splitting the ACLs onto both the ingress and egress pipelines allows
all the egress network policies to be evaluated followed by the ingress
so correct action is always assured

Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
this brings in options for ACLs required for ACL egress pipeline to
apply after load balancing

Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Apr 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2022

@JacobTanenbaum: This pull request references Bugzilla bug 2070703, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

Bug 2070703: WIP change networkpolicy ACLs to use "apply-after-lb" for egress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JacobTanenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2022
@JacobTanenbaum
Copy link
Contributor Author

/retest

4 similar comments
@JacobTanenbaum
Copy link
Contributor Author

/retest

@JacobTanenbaum
Copy link
Contributor Author

/retest

@JacobTanenbaum
Copy link
Contributor Author

/retest

@JacobTanenbaum
Copy link
Contributor Author

/retest

@JacobTanenbaum JacobTanenbaum changed the title Bug 2070703: WIP change networkpolicy ACLs to use "apply-after-lb" for egress Bug 2070703: change networkpolicy ACLs to use "apply-after-lb" for egress Apr 6, 2022
@JacobTanenbaum
Copy link
Contributor Author

/retest

@JacobTanenbaum
Copy link
Contributor Author

the changes I am backporting here where brought in by the downstream merge PR: #1010
commit: 1366fb3

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2022

@JacobTanenbaum: This pull request references Bugzilla bug 2070703. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Bug 2070703: change networkpolicy ACLs to use "apply-after-lb" for egress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2022

@JacobTanenbaum: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade f84d086 link false /test 4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-upgrade-local-gateway f84d086 link true /test e2e-aws-ovn-upgrade-local-gateway
ci/prow/e2e-openstack-ovn f84d086 link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant