-
Notifications
You must be signed in to change notification settings - Fork 126
image: Switch to ostree-format: oci
#619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image: Switch to ostree-format: oci
#619
Conversation
This is the RHCOS version of coreos/fedora-coreos-config#1097 I was hoping to land this in FCOS first but I'm kind of blocked on that in coreos/fedora-coreos-pipeline#359, so let's settle for parallel. NOTE! This **does not change** the effect of `cosa upload-oscontainer` etc. Some discussion on that here: ostreedev/ostree-rs-ext#23 and I will file more issues related to that. However, what this *will* do is allow us to push this *additional* image arounnd and make `podman run registry.ci.openshift.org/rhcos/rhcos:4.8` e.g. work. In other words to start this will just be something *we* use to quickly inspect rhcos-as-container, not something we actually ship. (OK that's kind of a lie, it will end up in a place like e.g. http://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/4.9.0-0.nightly-2021-07-20-014024/ instead of the existing `ostree.tar` so in theory other people outside of our group could run it too, but 🤫)
Exciting, this must be a regression from coreos/coreos-assembler#2418 |
|
/test build-test-qemu |
|
/retest |
|
This is a result of #616 and it looks like that package isn't tagged for 4.10; I'll have to internally request it is tagged again |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
OK let's give this another try? |
|
/hold |
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is the 3rd attempt at this, trying again now that
masteris 4.10 and coreos/coreos-assembler#2403 merged.This is the RHCOS version of coreos/fedora-coreos-config#1097
I was hoping to land this in FCOS first but I'm kind of blocked
on that in coreos/fedora-coreos-pipeline#359, so
let's settle for parallel.
NOTE! This does not change the effect of
cosa upload-oscontaineretc.Some discussion on that here:
ostreedev/ostree-rs-ext#23
and I will file more issues related to that.
However, what this will do is allow us to push this additional image
around and make
podman run registry.ci.openshift.org/rhcos/rhcos:4.8e.g.work. In other words to start this will just be something we use
to quickly inspect rhcos-as-container, not something we actually ship.
(OK that's kind of a lie, it will end up in a place like e.g.
http://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/4.9.0-0.nightly-2021-07-20-014024/
instead of the existing
ostree.tarso in theory other people outsideof our group could run it too, but 🤫)