Skip to content

Conversation

@cgwalters
Copy link
Member

@cgwalters cgwalters commented Sep 8, 2021

This is the 3rd attempt at this, trying again now that master is 4.10 and coreos/coreos-assembler#2403 merged.

This is the RHCOS version of coreos/fedora-coreos-config#1097

I was hoping to land this in FCOS first but I'm kind of blocked
on that in coreos/fedora-coreos-pipeline#359, so
let's settle for parallel.

NOTE! This does not change the effect of cosa upload-oscontainer etc.
Some discussion on that here:
ostreedev/ostree-rs-ext#23
and I will file more issues related to that.

However, what this will do is allow us to push this additional image
around and make podman run registry.ci.openshift.org/rhcos/rhcos:4.8 e.g.
work. In other words to start this will just be something we use
to quickly inspect rhcos-as-container, not something we actually ship.
(OK that's kind of a lie, it will end up in a place like e.g.
http://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/4.9.0-0.nightly-2021-07-20-014024/
instead of the existing ostree.tar so in theory other people outside
of our group could run it too, but 🤫)

This is the RHCOS version of coreos/fedora-coreos-config#1097

I was hoping to land this in FCOS first but I'm kind of blocked
on that in coreos/fedora-coreos-pipeline#359, so
let's settle for parallel.

NOTE!  This **does not change** the effect of `cosa upload-oscontainer` etc.
Some discussion on that here:
ostreedev/ostree-rs-ext#23
and I will file more issues related to that.

However, what this *will* do is allow us to push this *additional* image
arounnd and make `podman run registry.ci.openshift.org/rhcos/rhcos:4.8` e.g.
work.  In other words to start this will just be something *we* use
to quickly inspect rhcos-as-container, not something we actually ship.
(OK that's kind of a lie, it will end up in a place like e.g.
 http://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/4.9.0-0.nightly-2021-07-20-014024/
 instead of the existing `ostree.tar` so in theory other people outside
 of our group could run it too, but 🤫)
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@cgwalters
Copy link
Member Author

 --- FAIL: coreos.ignition.systemd.enable-service (61.19s)
        cluster.go:206: cmd systemctl status nfs-server.service did not output inactive 

Exciting, this must be a regression from coreos/coreos-assembler#2418

@cgwalters
Copy link
Member Author

@miabbott
Copy link
Member

miabbott commented Sep 8, 2021

/test build-test-qemu

@cgwalters
Copy link
Member Author

/retest

@miabbott
Copy link
Member

miabbott commented Sep 9, 2021

Cannot download Packages/container-selinux-2.167.0-1.module%2bel8.5.0%2b12397%2bbf23b712__noarch/container-selinux-2.167.0-1.module%2bel8.5.0%2b12397%2bbf23b712.noarch.rpm

This is a result of #616 and it looks like that package isn't tagged for 4.10; I'll have to internally request it is tagged again

@cgwalters
Copy link
Member Author

/retest

2 similar comments
@cgwalters
Copy link
Member Author

/retest

@cgwalters
Copy link
Member Author

/retest

@cgwalters
Copy link
Member Author

OK let's give this another try?

@cgwalters
Copy link
Member Author

/hold
for 4.9 branching

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2021
@cgwalters
Copy link
Member Author

/hold cancel
since I think we're already tracking release-4.9 and this can go in master.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2021
@jlebon
Copy link
Member

jlebon commented Sep 20, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants