kola: Add an AssertCmdOutputContains #2418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup to previous work on `RunCmdSync` which is aiming to clean up how we run processes. The rationale for this helper is much the same as APIs like https://pkg.go.dev/github.com/stretchr/testify@v1.7.0/assert#Contains It encapsulates this common pattern in a single line. Also unlike `MustSSH`, we log the command to the systemd journal too.
lucab
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to previous work on
RunCmdSyncwhich is aimingto clean up how we run processes.
The rationale for this helper is much the same as APIs like
https://pkg.go.dev/github.com/stretchr/testify@v1.7.0/assert#Contains
It encapsulates this common pattern in a single line.
Also unlike
MustSSH, we log the command to the systemd journaltoo.