kola/systemd: Fix regression in previous commit #2419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miabbott
previously approved these changes
Sep 8, 2021
Member
miabbott
left a comment
miabbott
left a comment
There was a problem hiding this comment.
I like the mechanism of systemctl show -p ActiveState for checking services; we should try to use that in more places where we are checking state. 👍
jlebon
reviewed
Sep 8, 2021
I missed the inverted logic here. Strengthen the test to actively check the service state instead of checking for the absence of `inactive` in the output text.
cgwalters
force-pushed
the
fix-contains
branch
from
6623afd to
ada5e87
Compare
jlebon
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed the inverted logic here. Strengthen the test
to actively check the service state instead of checking for the
absence of
inactivein the output text.