Skip to content

Conversation

@fidencio
Copy link

@fidencio fidencio commented Mar 25, 2021

This reworks af93514 as, since it was
merged, a few changes happened in the enhancement proposal and it's been
decided to go with a "sandboxed-containers" extensions instead.

As the "qemu-kiwi" extension is no longer needed, we're removing it
(well, reworking it) and adding the "sandboxed-containers" one instead.

The sandboxed-containers extension is added to the MCO with by the
following PR:
openshift/machine-config-operator#2456

Signed-off-by: Fabiano Fidêncio [email protected]

@fidencio
Copy link
Author

On a note, I'm note sure if I need to list all the dependencies as I did, but better be safe than sorry here.

@fidencio fidencio force-pushed the wip/sandboxed-containers-extension branch 2 times, most recently from 312c208 to 0c0278a Compare March 25, 2021 13:31
@fidencio
Copy link
Author

/hold till we have the kata-containers RPM released.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2021
@fidencio fidencio force-pushed the wip/sandboxed-containers-extension branch from 0c0278a to d71cdc3 Compare March 26, 2021 11:31
@fidencio
Copy link
Author

@fidencio
Copy link
Author

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2021
@miabbott
Copy link
Member

This one depends on https://gitlab.cee.redhat.com/coreos/redhat-coreos/-/merge_requests/1242

This PR can actually merge without that change; but to make CI pass, you'll need to update the openshift/release repo with a PR for the rhocp repo similar to what was done here - openshift/release#16258

@fidencio
Copy link
Author

This one depends on https://gitlab.cee.redhat.com/coreos/redhat-coreos/-/merge_requests/1242

This PR can actually merge without that change; but to make CI pass, you'll need to update the openshift/release repo with a PR for the rhocp repo similar to what was done here - openshift/release#16258

Aha! On that, thanks for the pointer!

@fidencio
Copy link
Author

/test build-test-qemu

@fidencio
Copy link
Author

/retest

3 similar comments
@fidencio
Copy link
Author

/retest

@fidencio
Copy link
Author

/retest

@fidencio
Copy link
Author

/retest

@cgwalters
Copy link
Member

rhel-8-rhocp': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried; Last error: Curl error (60): SSL peer certificate or SSH remote key was not OK for https://cdn.redhat.com/content/dist/layered/rhel8/x86_64/rhocp/4.8/os/repodata/repomd.xml [SSL certificate problem: self signed certificate in certificate chain]

Odd that it's just failing for that repo but not the others.

@cgwalters
Copy link
Member

@miabbott
Copy link
Member

rhel-8-rhocp': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried; Last error: Curl error (60): SSL peer certificate or SSH remote key was not OK for https://cdn.redhat.com/content/dist/layered/rhel8/x86_64/rhocp/4.8/os/repodata/repomd.xml [SSL certificate problem: self signed certificate in certificate chain]

Odd that it's just failing for that repo but not the others.

Since that repo was just added to the release-controller today, I'm going to guess it missed the nightly repo sync that happens.

@miabbott
Copy link
Member

openshift/release#17198 (comment)

Fabiano fixed the baseurl in openshift/release#17202

@fidencio
Copy link
Author

/hold for now, till the release situation of the kata-containers package is solved.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2021
@fidencio fidencio force-pushed the wip/sandboxed-containers-extension branch from d71cdc3 to 8bccb0a Compare March 31, 2021 20:04
@fidencio
Copy link
Author

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2021
@fidencio
Copy link
Author

/test build-test-qemu

1 similar comment
@fidencio
Copy link
Author

fidencio commented Apr 1, 2021

/test build-test-qemu

@fidencio
Copy link
Author

fidencio commented Apr 1, 2021

/retest

@fidencio fidencio force-pushed the wip/sandboxed-containers-extension branch from 8bccb0a to 9a62de1 Compare April 1, 2021 06:43
@fidencio
Copy link
Author

fidencio commented Apr 1, 2021

@miabbott, @cgwalters, CI has finally passed on this one (yay!). I think we can have this one merged sooner than later and it'll unblock the MCO PR.

@fidencio
Copy link
Author

fidencio commented Apr 1, 2021

/retest

This reworks af93514 as, since it was
merged, a few changes happened in the enhancement proposal and it's been
decided to go with a "sandboxed-containers" extensions instead.

As the "qemu-kiwi" extension is no longer needed, we're removing it
(well, reworking it) and adding the "sandboxed-containers" one instead.

The sandboxed-containers extension is added to the MCO with by the
following PR:
openshift/machine-config-operator#2456

Signed-off-by: Fabiano Fidêncio <[email protected]>
@fidencio fidencio force-pushed the wip/sandboxed-containers-extension branch from 9a62de1 to 21b7984 Compare April 1, 2021 07:45
@miabbott
Copy link
Member

miabbott commented Apr 1, 2021

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fidencio, miabbott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit 929d5e9 into openshift:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants