-
Notifications
You must be signed in to change notification settings - Fork 126
Add sandboxed-containers extension #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sandboxed-containers extension #525
Conversation
|
On a note, I'm note sure if I need to list all the dependencies as I did, but better be safe than sorry here. |
312c208 to
0c0278a
Compare
|
/hold till we have the kata-containers RPM released. |
0c0278a to
d71cdc3
Compare
|
This one depends on https://gitlab.cee.redhat.com/coreos/redhat-coreos/-/merge_requests/1242 |
|
/unhold |
This PR can actually merge without that change; but to make CI pass, you'll need to update the |
Aha! On that, thanks for the pointer! |
|
/test build-test-qemu |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
Odd that it's just failing for that repo but not the others. |
Since that repo was just added to the release-controller today, I'm going to guess it missed the nightly repo sync that happens. |
|
Fabiano fixed the baseurl in openshift/release#17202 |
|
/hold for now, till the release situation of the |
d71cdc3 to
8bccb0a
Compare
|
/unhold |
|
/test build-test-qemu |
1 similar comment
|
/test build-test-qemu |
|
/retest |
8bccb0a to
9a62de1
Compare
|
@miabbott, @cgwalters, CI has finally passed on this one (yay!). I think we can have this one merged sooner than later and it'll unblock the MCO PR. |
|
/retest |
This reworks af93514 as, since it was merged, a few changes happened in the enhancement proposal and it's been decided to go with a "sandboxed-containers" extensions instead. As the "qemu-kiwi" extension is no longer needed, we're removing it (well, reworking it) and adding the "sandboxed-containers" one instead. The sandboxed-containers extension is added to the MCO with by the following PR: openshift/machine-config-operator#2456 Signed-off-by: Fabiano Fidêncio <[email protected]>
9a62de1 to
21b7984
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fidencio, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reworks af93514 as, since it was
merged, a few changes happened in the enhancement proposal and it's been
decided to go with a "sandboxed-containers" extensions instead.
As the "qemu-kiwi" extension is no longer needed, we're removing it
(well, reworking it) and adding the "sandboxed-containers" one instead.
The sandboxed-containers extension is added to the MCO with by the
following PR:
openshift/machine-config-operator#2456
Signed-off-by: Fabiano Fidêncio [email protected]