Skip to content

Conversation

@fidencio
Copy link

This is a follow-up of d4c52d9, which
contained the wrong baseurl for the rhel-8-rhocp repo.

Sorry for the c&p mistake. /o\

Signed-off-by: Fabiano Fidêncio [email protected]

@fidencio
Copy link
Author

@bradmwilliams, sorry for the mistake in the previous PR. /o.

Copy link
Contributor

@bradmwilliams bradmwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2021
@fidencio fidencio force-pushed the wip/fix-rhocp-baseurl branch from 0aacd34 to 6ced466 Compare March 26, 2021 16:10
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2021
Copy link
Contributor

@bradmwilliams bradmwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2021
@bradmwilliams
Copy link
Contributor

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2021
@bradmwilliams
Copy link
Contributor

@fidencio It looks like there might be a funny swap file in your PR. It's showing as BIN

@bradmwilliams
Copy link
Contributor

Please check:
core-services/release-controller/_repos/.ocp-4.8-rhel8.repo.swo

This is a follow-up of d4c52d9, which
contained the wrong baseurl for the rhel-8-rhocp repo.

Sorry for the c&p mistake. /o\

Signed-off-by: Fabiano Fidêncio <[email protected]>
@fidencio fidencio force-pushed the wip/fix-rhocp-baseurl branch from 6ced466 to 73bbd29 Compare March 26, 2021 16:21
Copy link
Contributor

@bradmwilliams bradmwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file:
core-services/release-controller/_repos/.ocp-4.8-rhel8.repo.swo

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2021
Copy link
Contributor

@bradmwilliams bradmwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fidencio
Copy link
Author

Please remove this file:
core-services/release-controller/_repos/.ocp-4.8-rhel8.repo.swo

@bradmwilliams, indeed, fixed. thanks!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, fidencio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2021
@bradmwilliams
Copy link
Contributor

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2021
@openshift-merge-robot openshift-merge-robot merged commit 89f532d into openshift:master Mar 26, 2021
@openshift-ci-robot
Copy link
Contributor

@fidencio: Updated the following 5 configmaps:

  • base-repos configmap in namespace ocp at cluster build02 using the following files:
    • key ocp-4.8-rhel8.repo using file core-services/release-controller/_repos/ocp-4.8-rhel8.repo
  • base-repos configmap in namespace ocp at cluster vsphere using the following files:
    • key ocp-4.8-rhel8.repo using file core-services/release-controller/_repos/ocp-4.8-rhel8.repo
  • base-repos configmap in namespace ocp at cluster api.ci using the following files:
    • key ocp-4.8-rhel8.repo using file core-services/release-controller/_repos/ocp-4.8-rhel8.repo
  • base-repos configmap in namespace ocp at cluster app.ci using the following files:
    • key ocp-4.8-rhel8.repo using file core-services/release-controller/_repos/ocp-4.8-rhel8.repo
  • base-repos configmap in namespace ocp at cluster build01 using the following files:
    • key ocp-4.8-rhel8.repo using file core-services/release-controller/_repos/ocp-4.8-rhel8.repo
Details

In response to this:

This is a follow-up of d4c52d9, which
contained the wrong baseurl for the rhel-8-rhocp repo.

Sorry for the c&p mistake. /o\

Signed-off-by: Fabiano Fidêncio [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants