-
Notifications
You must be signed in to change notification settings - Fork 2.1k
release-controller: Fix "rhocp" baseurl #17202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-controller: Fix "rhocp" baseurl #17202
Conversation
|
@bradmwilliams, sorry for the mistake in the previous PR. /o. |
bradmwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
0aacd34 to
6ced466
Compare
bradmwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/hold |
|
@fidencio It looks like there might be a funny swap file in your PR. It's showing as |
|
Please check: |
This is a follow-up of d4c52d9, which contained the wrong baseurl for the rhel-8-rhocp repo. Sorry for the c&p mistake. /o\ Signed-off-by: Fabiano Fidêncio <[email protected]>
6ced466 to
73bbd29
Compare
bradmwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file:
core-services/release-controller/_repos/.ocp-4.8-rhel8.repo.swo
bradmwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@bradmwilliams, indeed, fixed. thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradmwilliams, fidencio The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
@fidencio: Updated the following 5 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a follow-up of d4c52d9, which
contained the wrong baseurl for the rhel-8-rhocp repo.
Sorry for the c&p mistake. /o\
Signed-off-by: Fabiano Fidêncio [email protected]