Add new extension for sandboxed-containers #2456

fidencio · 2021-03-09T11:27:23Z

- What I did
This adds support for a new RHCOS extension called
"sandboxed-containres". It will install kata-containers and its
dependencies, 9 RPMs with a total size of ~55MB when downloaded, ~150MB
when installed.

It will allow users to run kernel isolated containers via the Sandboxed
Containers operator.

- How to verify it
TBD

- Description for the changelog
Added support for a new RHCOS extension to install sandboxed-containers.

IMPORTANT:
Let me add a big note here that I'm experimenting with the fact of having a kata-containers extension, superseding #2376, and it comes from a suggestion made by @cgwalters while reviewing openshift/enhancements#677 (comment) (also, refer to: https://coreos.slack.com/archives/CK1AE4ZCK/p1614974860056400).

While modifying openshift/enhancements#677 according to the reviewers suggestions, I'm experimenting, I'm trying to have all the pieces together, so we can make the proposal solid and based on work that's either done or close to be done, rather than basing it on what we think that should be done.

fidencio · 2021-03-09T11:27:31Z

/hold

fidencio · 2021-03-09T11:27:55Z

NOTE: As it's right now, this is a test to see whether we can easiler supersede #2376, if needed.

pkg/daemon/update.go

test/e2e/mcd_test.go

fidencio · 2021-03-11T11:27:00Z

I've updated the PR according to @sinnykumari's review. (thanks!)

fidencio · 2021-03-25T10:11:05Z

@sinnykumari, as this one supersedes #2376, can we have the 4.8 label added to this one?

@jensfr, can we have #2376 closed?

fidencio · 2021-03-25T10:11:34Z

/retest

jensfr · 2021-03-25T10:36:03Z

@jensfr, can we have #2376 closed?

done

sinnykumari · 2021-03-25T11:16:59Z

@sinnykumari, as this one supersedes #2376, can we have the 4.8 label added to this one?

added 4.8 label. Once you have machine-os-content updated with correct set of packages, let us know in the PR.

This reworks af93514 as, since it was merged, a few changes happened in the enhancement proposal and it's been decided to go with a "sandboxed-containers" extensions instead. As the "qemu-kiwi" extension is no longer needed, we're removing it (well, reworking it) and adding the "sandboxed-containers" one instead. Last but not least, I've explicitly mentioned where each dependency is coming from (either advanced-virt, or appstream), so we know all the packages we're dealing with and where those come from. The sandboxed-containers extension is added to the MCO with by the following PR: openshift/machine-config-operator#2456 Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>

fidencio · 2021-03-26T12:15:52Z

This PR has been updated, and depends on openshift/os#525 (which depends on a downstream PR).

This reworks af93514 as, since it was merged, a few changes happened in the enhancement proposal and it's been decided to go with a "sandboxed-containers" extensions instead. As the "qemu-kiwi" extension is no longer needed, we're removing it (well, reworking it) and adding the "sandboxed-containers" one instead. Last but not least, I've explicitly mentioned where each dependency is coming from (either advanced-virt, or appstream), so we know all the packages we're dealing with and where those come from. The sandboxed-containers extension is added to the MCO with by the following PR: openshift/machine-config-operator#2456 Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>

This reworks af93514 as, since it was merged, a few changes happened in the enhancement proposal and it's been decided to go with a "sandboxed-containers" extensions instead. As the "qemu-kiwi" extension is no longer needed, we're removing it (well, reworking it) and adding the "sandboxed-containers" one instead. The sandboxed-containers extension is added to the MCO with by the following PR: openshift/machine-config-operator#2456 Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>

fidencio · 2021-04-02T05:07:51Z

/retest

fidencio · 2021-04-02T10:32:38Z

/retest

fidencio · 2021-04-02T15:01:52Z

/retest

fidencio · 2021-04-02T20:27:13Z

/retest

fidencio · 2021-04-05T08:59:41Z

/retest

sinnykumari

looks clean, thanks for the PR!
/lgtm

openshift-bot · 2021-04-06T09:47:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

fidencio · 2021-04-06T11:33:17Z

/retest

openshift-ci-robot · 2021-04-06T12:28:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fidencio, JAORMX, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fidencio · 2021-04-06T12:33:28Z

/retest

openshift-bot · 2021-04-06T12:36:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-06T14:20:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

fidencio · 2021-04-06T14:58:12Z

/test e2e-agnostic-upgrade

openshift-bot · 2021-04-06T17:22:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-06T18:54:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-06T19:32:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-06T20:37:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-06T20:50:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

fidencio · 2021-04-06T22:08:04Z

/test e2e-aws-serial

openshift-bot · 2021-04-06T23:39:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-07T00:18:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-07T00:44:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-07T01:23:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-07T04:51:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-04-07T06:05:34Z

@fidencio: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-workers-rhel7	`8d27bf8`	link	`/test e2e-aws-workers-rhel7`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2021

openshift-ci-robot requested review from sinnykumari and yuqi-zhang March 9, 2021 11:28

fidencio changed the title ~~Add new extension for qemu-kiwi~~ Add new extension for sandboxed-containers Mar 9, 2021

fidencio force-pushed the wip/add-sandboxed-containers-extensions branch 3 times, most recently from 198e081 to 70b4912 Compare March 9, 2021 12:25

sinnykumari reviewed Mar 11, 2021

View reviewed changes

pkg/daemon/update.go Outdated Show resolved Hide resolved

sinnykumari reviewed Mar 11, 2021

View reviewed changes

test/e2e/mcd_test.go Outdated Show resolved Hide resolved

fidencio force-pushed the wip/add-sandboxed-containers-extensions branch from 70b4912 to d404023 Compare March 11, 2021 11:26

fidencio force-pushed the wip/add-sandboxed-containers-extensions branch from d404023 to 0b06a80 Compare March 11, 2021 11:33

jensfr mentioned this pull request Mar 25, 2021

Add new extension for qemu-kiwi #2376

Closed

sinnykumari added the 4.8 Work deferred for 4.8 label Mar 25, 2021

fidencio mentioned this pull request Mar 25, 2021

Add sandboxed-containers extension openshift/os#525

Merged

fidencio force-pushed the wip/add-sandboxed-containers-extensions branch from 0b06a80 to 3625f08 Compare March 26, 2021 12:13

fidencio force-pushed the wip/add-sandboxed-containers-extensions branch from 3625f08 to 5d9dbeb Compare March 31, 2021 20:06

sinnykumari approved these changes Apr 6, 2021

View reviewed changes

openshift-ci-robot assigned sinnykumari Apr 6, 2021

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 6, 2021

JAORMX approved these changes Apr 6, 2021

View reviewed changes

openshift-merge-robot merged commit ca8fcb8 into openshift:master Apr 7, 2021

Add new extension for sandboxed-containers #2456

Add new extension for sandboxed-containers #2456

Uh oh!

Conversation

fidencio commented Mar 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fidencio commented Mar 9, 2021

Uh oh!

fidencio commented Mar 9, 2021

Uh oh!

Uh oh!

Uh oh!

fidencio commented Mar 11, 2021

Uh oh!

fidencio commented Mar 25, 2021

Uh oh!

fidencio commented Mar 25, 2021

Uh oh!

jensfr commented Mar 25, 2021

Uh oh!

sinnykumari commented Mar 25, 2021

Uh oh!

fidencio commented Mar 26, 2021

Uh oh!

fidencio commented Apr 2, 2021

Uh oh!

fidencio commented Apr 2, 2021

Uh oh!

fidencio commented Apr 2, 2021

Uh oh!

fidencio commented Apr 2, 2021

Uh oh!

fidencio commented Apr 5, 2021

Uh oh!

sinnykumari left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Apr 6, 2021

Uh oh!

fidencio commented Apr 6, 2021

Uh oh!

openshift-ci-robot commented Apr 6, 2021

Uh oh!

fidencio commented Apr 6, 2021

Uh oh!

openshift-bot commented Apr 6, 2021

Uh oh!

openshift-bot commented Apr 6, 2021

Uh oh!

fidencio commented Apr 6, 2021

Uh oh!

openshift-bot commented Apr 6, 2021

Uh oh!

openshift-bot commented Apr 6, 2021

Uh oh!

openshift-bot commented Apr 6, 2021

Uh oh!

openshift-bot commented Apr 6, 2021

Uh oh!

openshift-bot commented Apr 6, 2021

Uh oh!

fidencio commented Apr 6, 2021

Uh oh!

openshift-bot commented Apr 6, 2021

Uh oh!

openshift-bot commented Apr 7, 2021

Uh oh!

openshift-bot commented Apr 7, 2021

Uh oh!

openshift-bot commented Apr 7, 2021

Uh oh!

openshift-bot commented Apr 7, 2021

Uh oh!

openshift-ci bot commented Apr 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

fidencio commented Mar 9, 2021 •

edited

Loading

openshift-ci bot commented Apr 7, 2021 •

edited

Loading