Skip to content

Conversation

@danwinship
Copy link
Contributor

We (will) block use of that API in OCP, so the test fails.

We block use of that API in OCP, so the test fails.
@openshift-trt
Copy link

openshift-trt bot commented Sep 14, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 99d2079

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack-local-gateway High - "[Monitor:legacy-test-framework-invariants][bz-networking][invariant] alert/OVNKubernetesResourceRetryFailure should not be at or above info" is a new test that failed 1 time(s) against the current commit

New tests seen in this PR at sha: 99d2079

  • "[Monitor:additional-events-collector][Jira:"Test Framework"] monitor test additional-events-collector cleanup" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:additional-events-collector][Jira:"Test Framework"] monitor test additional-events-collector collection" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:additional-events-collector][Jira:"Test Framework"] monitor test additional-events-collector interval construction" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:additional-events-collector][Jira:"Test Framework"] monitor test additional-events-collector preparation" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:additional-events-collector][Jira:"Test Framework"] monitor test additional-events-collector setup" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:additional-events-collector][Jira:"Test Framework"] monitor test additional-events-collector test evaluation" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:additional-events-collector][Jira:"Test Framework"] monitor test additional-events-collector writing to storage" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:alert-summary-serializer][Jira:"Test Framework"] monitor test alert-summary-serializer cleanup" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:alert-summary-serializer][Jira:"Test Framework"] monitor test alert-summary-serializer collection" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:alert-summary-serializer][Jira:"Test Framework"] monitor test alert-summary-serializer interval construction" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:alert-summary-serializer][Jira:"Test Framework"] monitor test alert-summary-serializer preparation" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:alert-summary-serializer][Jira:"Test Framework"] monitor test alert-summary-serializer setup" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:alert-summary-serializer][Jira:"Test Framework"] monitor test alert-summary-serializer test evaluation" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:alert-summary-serializer][Jira:"Test Framework"] monitor test alert-summary-serializer writing to storage" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:api-unreachable-from-client-metrics][Jira:"kube-apiserver"] monitor test api-unreachable-from-client-metrics cleanup" [Total: 36, Pass: 36, Fail: 0, Flake: 0]
  • "[Monitor:api-unreachable-from-client-metrics][Jira:"kube-apiserver"] monitor test api-unreachable-from-client-metrics collection" [Total: 36, Pass: 36, Fail: 0, Flake: 0]
  • "[Monitor:api-unreachable-from-client-metrics][Jira:"kube-apiserver"] monitor test api-unreachable-from-client-metrics interval construction" [Total: 36, Pass: 36, Fail: 0, Flake: 0]
  • "[Monitor:api-unreachable-from-client-metrics][Jira:"kube-apiserver"] monitor test api-unreachable-from-client-metrics preparation" [Total: 38, Pass: 38, Fail: 0, Flake: 0]
  • "[Monitor:api-unreachable-from-client-metrics][Jira:"kube-apiserver"] monitor test api-unreachable-from-client-metrics setup" [Total: 36, Pass: 36, Fail: 0, Flake: 0]
  • "[Monitor:api-unreachable-from-client-metrics][Jira:"kube-apiserver"] monitor test api-unreachable-from-client-metrics test evaluation" [Total: 36, Pass: 36, Fail: 0, Flake: 0]
  • (...showing 20 of 1966 tests)

@danwinship
Copy link
Contributor Author

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 15, 2025
@openshift-ci-robot
Copy link

@danwinship: This PR has been marked as verified by @danwinship.

Details

In response to this:

/verified by @danwinship

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1967238576965947392 (e2e-serial run with this PR plus openshift/cluster-network-operator#2797) failed on an unrelated test; the etcd test passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danwinship danwinship changed the title Skip ServiceCIDR in etcd_storage_path test OCPBUGS-61196: Skip ServiceCIDR in etcd_storage_path test Sep 15, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 15, 2025
@openshift-ci-robot
Copy link

@danwinship: This pull request references Jira Issue OCPBUGS-61196, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We (will) block use of that API in OCP, so the test fails.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danwinship
Copy link
Contributor Author

/auto-cc

@danwinship
Copy link
Contributor Author

Also has a backport to 4.20, #30257

@danwinship
Copy link
Contributor Author

/assign @bertinatto
looks like you mostly own this file...
(also, if this is OK, see also the backport PR, #30257)

@bertinatto
Copy link
Member

/assign @bertinatto looks like you mostly own this file... (also, if this is OK, see also the backport PR, #30257)

/lgtm

I'm not very familiar with this, but this seems OK.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a1c4836 and 2 for PR HEAD 99d2079 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 922dcc6 and 1 for PR HEAD 99d2079 in total

@danwinship
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3fe2f9a and 2 for PR HEAD 99d2079 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3fe2f9a and 2 for PR HEAD 99d2079 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2025

@danwinship: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-techpreview 99d2079 link false /test e2e-gcp-ovn-techpreview
ci/prow/e2e-aws-ovn 99d2079 link false /test e2e-aws-ovn
ci/prow/e2e-openstack-ovn 99d2079 link false /test e2e-openstack-ovn
ci/prow/okd-scos-e2e-aws-ovn 99d2079 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway 99d2079 link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 99d2079 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-disruptive 99d2079 link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3fe2f9a and 2 for PR HEAD 99d2079 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 91bb880 into openshift:main Sep 19, 2025
40 of 47 checks passed
@openshift-ci-robot
Copy link

@danwinship: Jira Issue OCPBUGS-61196: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-61196 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

We (will) block use of that API in OCP, so the test fails.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danwinship danwinship deleted the servicecidr-serial branch September 19, 2025 14:36
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.21.0-0.nightly-2025-10-02-215712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants