-
Notifications
You must be signed in to change notification settings - Fork 127
OCPBUGS-61196: UPSTREAM: 133625: Remove patch/update from ServiceCIDR API conformanc… #2444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-61196: UPSTREAM: 133625: Remove patch/update from ServiceCIDR API conformanc… #2444
Conversation
…e test They were already listed in ineligible_endpoints.yaml, so we shouldn't be testing them here anyway. (cherry picked from commit 9d09997)
|
@danwinship: This pull request references Jira Issue OCPBUGS-61196, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@danwinship: the contents of this pull request could be automatically validated. The following commits are valid:
Comment |
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
@danwinship: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by @danwinship used clusterbot to |
|
@danwinship: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@danwinship: Jira Issue OCPBUGS-61196: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged: All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-61196 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.21.0-0.nightly-2025-10-02-215712 |
Pulls a conformance test fix from release-1.33 upstream so that we can merge openshift/cluster-network-operator#2605 without it breaking conformance. (The ServiceCIDR API is supposed to be disable-able, but the conformance test was accidentally requiring it not to be.)
This missed 4.20 feature freeze because the test wasn't fixed upstream in time, so I'm cherry-picking the PR to openshift/kubernetes master first, and will then cherry-pick it to openshift/release-4.20. Right?