Skip to content

Conversation

@danwinship
Copy link

Pulls a conformance test fix from release-1.33 upstream so that we can merge openshift/cluster-network-operator#2605 without it breaking conformance. (The ServiceCIDR API is supposed to be disable-able, but the conformance test was accidentally requiring it not to be.)

This missed 4.20 feature freeze because the test wasn't fixed upstream in time, so I'm cherry-picking the PR to openshift/kubernetes master first, and will then cherry-pick it to openshift/release-4.20. Right?

…e test

They were already listed in ineligible_endpoints.yaml, so we shouldn't
be testing them here anyway.

(cherry picked from commit 9d09997)
@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 3, 2025
@openshift-ci-robot
Copy link

@danwinship: This pull request references Jira Issue OCPBUGS-61196, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Pulls a conformance test fix from release-1.33 upstream so that we can merge openshift/cluster-network-operator#2605 without it breaking conformance. (The ServiceCIDR API is supposed to be disable-able, but the conformance test was accidentally requiring it not to be.)

This missed 4.20 feature freeze because the test wasn't fixed upstream in time, so I'm cherry-picking the PR to openshift/kubernetes master first, and will then cherry-pick it to openshift/release-4.20. Right?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@danwinship: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@danwinship
Copy link
Author

/retest-required

@bertinatto
Copy link
Member

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2025
@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2025
@danwinship
Copy link
Author

/retest-required
ipv6 timeout, openshift/release#68890

@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2025

@danwinship: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danwinship
Copy link
Author

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 5, 2025
@openshift-ci-robot
Copy link

@danwinship: This PR has been marked as verified by @danwinship.

Details

In response to this:

/verified by @danwinship

used clusterbot to test e2e 4.21,openshift/kubernetes#2444,openshift/cluster-network-operator#2605

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit bc561b2 into openshift:master Sep 5, 2025
25 checks passed
@openshift-ci-robot
Copy link

@danwinship: Jira Issue OCPBUGS-61196: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-61196 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

Pulls a conformance test fix from release-1.33 upstream so that we can merge openshift/cluster-network-operator#2605 without it breaking conformance. (The ServiceCIDR API is supposed to be disable-able, but the conformance test was accidentally requiring it not to be.)

This missed 4.20 feature freeze because the test wasn't fixed upstream in time, so I'm cherry-picking the PR to openshift/kubernetes master first, and will then cherry-pick it to openshift/release-4.20. Right?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.21.0-0.nightly-2025-10-02-215712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants