OCPBUGS-61196: Add a ValidatingAdmissionPolicy blocking ServiceCIDR changes #2797
Conversation
OCP does not yet support changing the service CIDRs at runtime.
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci-robot
added
jira/valid-reference
|
@danwinship: This pull request references Jira Issue OCPBUGS-61196, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
3 similar comments
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
/test e2e-aws-ovn-serial-1of2 /retest-required |
|
/hold cancel serial tests pass now that openshift/origin#30254 has merged, so this can merge again. (It's unchanged from #2605, we just needed the e2e test fix first so merging this doesn't break other repos.) |
openshift-ci
bot
removed
the
do-not-merge/hold
|
oops, Patryk is on vacation |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpickard22, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/verified by "ServiceCIDR should be blocked" (new test from openshift/origin#30234, which can merge after this does. Test run at https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1965905253861691392.) |
openshift-ci-robot
added
the
verified
|
@danwinship: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/override ci/prow/e2e-aws-ovn-upgrade-ipsec |
|
@danwinship: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ovn-upgrade-ipsec |
|
@danwinship: Overrode contexts on behalf of danwinship: ci/prow/e2e-aws-ovn-upgrade-ipsec, ci/prow/e2e-aws-ovn-windows, ci/prow/e2e-ovn-ipsec-step-registry DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@danwinship: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 23c976c
into
openshift:master
|
@danwinship: Jira Issue OCPBUGS-61196: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-61196 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.21.0-0.nightly-2025-10-02-215712 |
5 participants
unrevert of #2605
(PR unchanged from #2605; the revert was not because the PR itself was buggy, but because it requires adding an exception to an e2e test, openshift/origin#30254.)
/hold
for e2e-serial test fix