OCPBUGS-54651: resources: Add limit exceptions for Istio#29690
Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom Apr 23, 2025
Merged
Conversation
Contributor
|
/retest-required |
Miciah
changed the title
Miciah
changed the title
Miciah
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@Miciah: This pull request references Jira Issue OCPBUGS-54651, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Miciah
force-pushed
the
resources-add-limit-exceptions-for-Istio
branch
from
5b76148 to
58c7917
Compare
Contributor
|
/test e2e-gcp-ovn-techpreview |
Contributor
|
@Miciah I did pre-merge test with this PR, the test passed but it is marked as flake. Is that OK? |
Contributor
Author
Yes, that is the expected behavior. We want the test result to be a flake and not a failure. What I intend to accomplish with the exception is to avoid the situation where the test fails once, then it gets retried, and then the retry fails. When this happens, the two failed attempts result in the test being reported as a failure. For example, https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29670/pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview/1912217692526350336 went from being a flake to being a failure because first the gateway deployment triggered the flake: and then a must-gather pod triggered the flake: Adding the exception for the gateway deployment should cause it to be marked immediately as a flake, instead of retrying and possibly failing again, resulting in a failure for the test. |
Contributor
|
Weird, why the test still failed in the e2e-gcp-ovn-techpreview ? |
Contributor
|
/test e2e-gcp-ovn-techpreview |
1 similar comment
Contributor
|
/test e2e-gcp-ovn-techpreview |
|
Job Failure Risk Analysis for sha: 58c7917
|
Member
|
/lgtm |
openshift-ci
bot
added
lgtm
Member
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Contributor
Author
Using search.ci, I found another failure: The test tries to map each replicaset to its owning deployment. In this case, it appears that the test found two replicasets, and the test could find the owning deployment for one of them but not for the other, and so we see deployment "gateway-w9pxj-openshift-default" and the replicasets for deployment "gateway-rms42-openshift-default". Perhaps an old replicaset got somehow left behind when its deployment was deleted? In any case, I believe that this is an error in the test logic. |
Miciah
force-pushed
the
resources-add-limit-exceptions-for-Istio
branch
from
58c7917 to
b283ded
Compare
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, candita, Miciah, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest-required |
Contributor
|
Some of the last AWS tests failed due to the quota issue. Trying one again: |
Contributor
|
Doesn't seem to be anymore issue with AWS leases. |
Contributor
|
/test e2e-gcp-ovn-techpreview |
1 similar comment
Contributor
|
/test e2e-gcp-ovn-techpreview |
Contributor
|
/retest-required |
Contributor
|
/test e2e-gcp-ovn-techpreview |
Contributor
Author
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Contributor
|
AWS is back up. |
Contributor
|
Cluster install failures related to:
/retest-required |
Contributor
|
/retest-required |
Contributor
|
/test e2e-gcp-ovn-techpreview |
Contributor
|
/retest-required |
Contributor
|
|
|
Job Failure Risk Analysis for sha: ed9a512
|
|
Job Failure Risk Analysis for sha: ed9a512
|
Contributor
|
@Miciah: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: ed9a512
|
|
Job Failure Risk Analysis for sha: ed9a512
|
openshift-merge-bot
bot
merged commit aa19c60
into
openshift:main
31 of 56 checks passed
|
@Miciah: Jira Issue OCPBUGS-54651: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-54651 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an exception for Istio pods that specify resource limits.