Skip to content

OCPBUGS-54651: resources: Add limit exceptions for Istio #29690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Apr 23, 2025
Merged

OCPBUGS-54651: resources: Add limit exceptions for Istio #29690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ead947
resources: Handle errors getting deployment
Miciah Apr 18, 2025
ed9a512
resources: Add limit exceptions for Istio
Miciah Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion test/extended/operators/resources.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (

g "github.com/onsi/ginkgo/v2"
v1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/kube-openapi/pkg/util/sets"
e2e "k8s.io/kubernetes/test/e2e/framework"
Expand Down Expand Up @@ -56,6 +57,10 @@ var _ = g.Describe("[sig-arch] Managed cluster", func() {
"batch/v1/Job/openshift-monitoring/<batch_job>/container/osd-rebalance-infra-nodes/request[cpu]": "https://issues.redhat.com/browse/OSD-21708",
"batch/v1/Job/openshift-monitoring/<batch_job>/container/osd-rebalance-infra-nodes/request[memory]": "https://issues.redhat.com/browse/OSD-21708",

// Istio pods
"apps/v1/Deployment/openshift-ingress/gateway/container/istio-proxy/limit[cpu]": "https://issues.redhat.com/browse/OCPBUGS-55050",
"apps/v1/Deployment/openshift-ingress/gateway/container/istio-proxy/limit[memory]": "https://issues.redhat.com/browse/OCPBUGS-55050",

// ovn pods
"apps/v1/DaemonSet/openshift-multus/cni-sysctl-allowlist-ds/container/kube-multus-additional-cni-plugins/request[cpu]": "https://issues.redhat.com/browse/TRT-1871",
"apps/v1/DaemonSet/openshift-multus/cni-sysctl-allowlist-ds/container/kube-multus-additional-cni-plugins/request[memory]": "https://issues.redhat.com/browse/TRT-1871",
Expand Down Expand Up @@ -123,8 +128,24 @@ var _ = g.Describe("[sig-arch] Managed cluster", func() {
case "ReplicaSet":
if i := strings.LastIndex(ref.Name, "-"); i != -1 {
name := ref.Name[0:i]
if deploy, err := oc.KubeFramework().ClientSet.AppsV1().Deployments(pod.Namespace).Get(context.Background(), name, metav1.GetOptions{}); err == nil {
if deploy, err := oc.KubeFramework().ClientSet.AppsV1().Deployments(pod.Namespace).Get(context.Background(), name, metav1.GetOptions{}); err != nil {
if apierrors.IsNotFound(err) {
e2e.Logf("ignoring replicaset %s because no owning deployment %s exists", ref.Name, name)
// Ignore this pod entirely because it most likely
// belongs to an orphaned replicaset.
continue podLoop
} else {
e2e.Failf("unable to get deployment %s for replicaset %s: %v", name, ref.Name, err)
}
} else {
ref.Name = deploy.Name
if pod.Namespace == "openshift-ingress" && strings.HasPrefix(ref.Name, "gateway-") {
// The gateway deployment's name contains a hash, which
// must be removed in order to be able to define an
// exception. Remove this if block when the
// corresponding exception is removed.
ref.Name = "gateway"
}
ref.Kind = "Deployment"
ref.APIVersion = "apps/v1"
}
Expand Down