NO-ISSUE: Add Capability and FeatureGate checks to OLMv1 tests #29283

tmshort · 2024-11-11T20:40:49Z

This required:

go get github.com/openshift/api@a2817b89f7e0989016967055a142d5e88bed18de
go get github.com/openshift/client-go@923091dd2b1a3d6fe75a06cc4f45972a3ddf84c2
go get github.com/openshift/library-go@0064ad7bd060b9fd52f7840972c1d3e72186d0f0
// update the replaces of k8s.io/kubernetes to github.com/openshift/[email protected] 
go mod tidy
go mod vendor

/hold until capability is fully implemented

openshift-ci · 2024-11-11T20:40:54Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tmshort · 2024-11-11T20:41:37Z

/test all

openshift-ci · 2024-11-12T14:23:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tmshort
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS
test/extended/util/image/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-11-12T14:54:16Z

@tmshort: This pull request explicitly references no jira issue.

Details

In response to this:

This required:

go get github.com/openshift/api@a2817b89f7e0989016967055a142d5e88bed18de
go get github.com/openshift/client-go@923091dd2b1a3d6fe75a06cc4f45972a3ddf84c2
go get github.com/openshift/library-go@0064ad7bd060b9fd52f7840972c1d3e72186d0f0
// update the replaces of k8s.io/kubernetes to github.com/openshift/[email protected] 
go mod tidy
go mod vendor

/hold until capability is fully implemented

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tmshort · 2024-11-12T18:03:56Z

/retest

tmshort · 2024-11-12T21:02:01Z

/retest

wking · 2024-11-12T21:11:30Z

test/extended/olm/olmv1.go

 })
+
+func checkTestSkip(ctx context.Context, oc *exutil.CLI) {
+	if !exutil.IsTechPreviewNoUpgrade(ctx, oc.AdminConfigClient()) {


is there a way for tests to check the NewOLM feature gate, so you have one less thing you need to bump when that is added to the default feature set? This line hard-codes the current state, where the NewOLM feature gate is in tech-preview, but not yet in the default feature set.

Done, I think...

I didn't get rid of the TechPreview check yet, because I wasn't sure of the status of the FeatureGate.

This required: go get github.com/openshift/api@a2817b89f7e0989016967055a142d5e88bed18de go get github.com/openshift/client-go@923091dd2b1a3d6fe75a06cc4f45972a3ddf84c2 go get github.com/openshift/library-go@0064ad7bd060b9fd52f7840972c1d3e72186d0f0 // update the replaces of k8s.io/kubernetes to github.com/openshift/[email protected] go mod tidy go mod vendor Signed-off-by: Todd Short <[email protected]>

Signed-off-by: Todd Short <[email protected]>

tmshort · 2024-11-13T03:00:55Z

/retest

tmshort · 2024-11-13T13:58:09Z

/retest

openshift-ci · 2024-11-13T18:09:45Z

@tmshort: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout	`adac1cd`	link	false	`/test e2e-metal-ipi-ovn-kube-apiserver-rollout`
ci/prow/e2e-gcp-ovn	`adac1cd`	link	true	`/test e2e-gcp-ovn`
ci/prow/e2e-metal-ipi-ovn-ipv6	`adac1cd`	link	true	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-aws-ovn-single-node-serial	`adac1cd`	link	false	`/test e2e-aws-ovn-single-node-serial`
ci/prow/e2e-aws-ovn-single-node-upgrade	`adac1cd`	link	false	`/test e2e-aws-ovn-single-node-upgrade`
ci/prow/e2e-metal-ipi-ovn	`adac1cd`	link	false	`/test e2e-metal-ipi-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-trt-bot · 2024-11-13T19:11:31Z

Job Failure Risk Analysis for sha: adac1cd

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout	High [sig-network] can collect pod-to-pod poller pod logs This test has passed 100.00% of 11 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-kube-apiserver-rollout'] in the last 14 days. --- [sig-arch][Late][Jira:"kube-apiserver"] collect certificate data [Suite:openshift/conformance/parallel] This test has passed 100.00% of 11 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-kube-apiserver-rollout'] in the last 14 days. --- [sig-network] can collect host-to-pod poller pod logs This test has passed 100.00% of 11 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-kube-apiserver-rollout'] in the last 14 days. --- [Jira:"Network / ovn-kubernetes"] monitor test pod-network-avalibility setup This test has passed 100.00% of 11 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-kube-apiserver-rollout'] in the last 14 days. --- Showing 4 of 6 test results
pull-ci-openshift-origin-master-e2e-gcp-ovn	High [sig-network-edge][Conformance][Area:Networking][Feature:Router] The HAProxy router should pass the gRPC interoperability tests [apigroup:route.openshift.io][apigroup:operator.openshift.io] [Suite:openshift/conformance/parallel/minimal] This test has passed 100.00% of 33 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6	IncompleteTests Tests for this run (101) are below the historical average (2704): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn	IncompleteTests Tests for this run (101) are below the historical average (2514): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

tmshort · 2024-11-14T13:47:32Z

Closing in favor of #29290

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 11, 2024

openshift-ci bot added the vendor-update Touching vendor dir or related files label Nov 11, 2024

tmshort force-pushed the add-olmv1-capability branch from 9717d62 to b635ba3 Compare November 11, 2024 20:59

tmshort marked this pull request as ready for review November 11, 2024 21:51

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2024

openshift-ci bot requested review from kevinrizza and sjenning November 11, 2024 21:52

tmshort force-pushed the add-olmv1-capability branch from b635ba3 to 0c977aa Compare November 12, 2024 14:23

openshift-ci bot added the e2e-images-update Related to images used by e2e tests label Nov 12, 2024

tmshort changed the title ~~Add Capability check to OLMv1 tests~~ NO-ISSUE: Add Capability check to OLMv1 tests Nov 12, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 12, 2024

tmshort mentioned this pull request Nov 12, 2024

OPRUN-3588: Add OLMv1 capability annotation to manifests openshift/cluster-olm-operator#78

Merged

wking reviewed Nov 12, 2024

View reviewed changes

tmshort force-pushed the add-olmv1-capability branch from 0c977aa to 8bc0bc2 Compare November 12, 2024 21:15

Add Capability and FeatureGate check to OLMv1 tests

4b1a1fc

Signed-off-by: Todd Short <[email protected]>

tmshort force-pushed the add-olmv1-capability branch from 8bc0bc2 to 4b1a1fc Compare November 12, 2024 21:33

tmshort changed the title ~~NO-ISSUE: Add Capability check to OLMv1 tests~~ NO-ISSUE: Add Capability and FeatureGate checks to OLMv1 tests Nov 12, 2024

Remove OLMv1 TechPreview check in favor of feature gate

adac1cd

Signed-off-by: Todd Short <[email protected]>

wking mentioned this pull request Nov 12, 2024

OPRUN-3588: Update openshift/api to pick up OLM V1 v4.18 capability sets openshift/cluster-version-operator#1108

Merged

tmshort mentioned this pull request Nov 13, 2024

OPRUN-3594: Add Capability and FeatureGate checks to OLMv1 tests #29290

Merged

perdasilva mentioned this pull request Nov 14, 2024

NO-ISSUE: Add Capability and FeatureGate checks to OLMv1 tests #29294

Closed

tmshort closed this Nov 14, 2024

tmshort deleted the add-olmv1-capability branch January 23, 2025 18:48

NO-ISSUE: Add Capability and FeatureGate checks to OLMv1 tests #29283

NO-ISSUE: Add Capability and FeatureGate checks to OLMv1 tests #29283

Uh oh!

Conversation

tmshort commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Nov 11, 2024

Uh oh!

tmshort commented Nov 11, 2024

Uh oh!

openshift-ci bot commented Nov 12, 2024

Uh oh!

openshift-ci-robot commented Nov 12, 2024

Uh oh!

tmshort commented Nov 12, 2024

Uh oh!

tmshort commented Nov 12, 2024

Uh oh!

wking Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

tmshort Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

tmshort Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

tmshort commented Nov 13, 2024

Uh oh!

tmshort commented Nov 13, 2024

Uh oh!

openshift-ci bot commented Nov 13, 2024

Uh oh!

openshift-trt-bot commented Nov 13, 2024

Uh oh!

tmshort commented Nov 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tmshort commented Nov 11, 2024 •

edited

Loading