Skip to content

OPRUN-3588: Add OLMv1 capability annotation to manifests #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 7 commits into from
Nov 13, 2024
Merged

OPRUN-3588: Add OLMv1 capability annotation to manifests #78

openshift-merge-bot merged 7 commits into from
Nov 13, 2024

Conversation

@perdasilva
Copy link

@perdasilva perdasilva commented Nov 7, 2024

Adds OLMv1 annotation to manifests

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2024 •
edited by openshift-ci bot
Loading

@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue.

Details

In response to this:

Adds OLMv1 annotation to manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from anik120 and joelanford November 7, 2024 16:40
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2024
@perdasilva perdasilva force-pushed the perdasilva/add-olmv1-capability-annotation branch from 43495a7 to 447a1f7 Compare November 8, 2024 17:40
@joelanford
Copy link
Member

joelanford commented Nov 9, 2024

/test openshift-e2e-aws-techpreview

1 similar comment
@joelanford
Copy link
Member

joelanford commented Nov 9, 2024

/test openshift-e2e-aws-techpreview

@perdasilva perdasilva force-pushed the perdasilva/add-olmv1-capability-annotation branch 3 times, most recently from 711d31c to 9f5c6c4 Compare November 11, 2024 09:38
Add OLMv1 capability annotation to manifests
137cf15 
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the perdasilva/add-olmv1-capability-annotation branch from 9f5c6c4 to 137cf15 Compare November 11, 2024 10:03
@thetechnick
Copy link
Contributor

thetechnick commented Nov 11, 2024

/retest

@tmshort
Copy link
Contributor

tmshort commented Nov 11, 2024

Appears that none of the manifests were applied.

Update library-go
b1b2e57 
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva
Copy link
Author

perdasilva commented Nov 12, 2024

/hold trying with custom (updated) library-go

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2024
Try updated library-go
1941a00 
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the perdasilva/add-olmv1-capability-annotation branch from fb6bf04 to 1941a00 Compare November 12, 2024 12:22
@tmshort
Copy link
Contributor

tmshort commented Nov 12, 2024

ci/prow/openshift-e2e-aws-techpreview is going to fail until openshift/origin#29283 is merged

@wking wking mentioned this pull request Nov 12, 2024
Merged
@joelanford joelanford force-pushed the perdasilva/add-olmv1-capability-annotation branch from 6762f78 to 19ed7aa Compare November 12, 2024 23:15
Per Goncalves da Silva added 3 commits November 13, 2024 16:11
Revert "Try updated library-go"
54554f6 
This reverts commit 1941a00.
Revert "Update library-go"
254d9a8 
This reverts commit b1b2e57.
Revert to lance's library-go branch
c8c4714 
Signed-off-by: Per Goncalves da Silva <[email protected]>
@joelanford
Copy link
Member

joelanford commented Nov 13, 2024

/hold cancel
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@joelanford
Copy link
Member

joelanford commented Nov 13, 2024

/override openshift-e2e-aws-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

@joelanford: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • openshift-e2e-aws-techpreview

Only the following failed contexts/checkruns were expected:

  • ci/prow/deps
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/okd-scos-e2e-aws-ovn
  • ci/prow/openshift-e2e-aws-techpreview
  • pull-ci-openshift-cluster-olm-operator-main-deps
  • pull-ci-openshift-cluster-olm-operator-main-images
  • pull-ci-openshift-cluster-olm-operator-main-lint
  • pull-ci-openshift-cluster-olm-operator-main-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-cluster-olm-operator-main-openshift-e2e-aws-techpreview
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override openshift-e2e-aws-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joelanford
Copy link
Member

joelanford commented Nov 13, 2024

/override ci/prow/openshift-e2e-aws-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

@joelanford: Overrode contexts on behalf of joelanford: ci/prow/openshift-e2e-aws-techpreview

Details

In response to this:

/override ci/prow/openshift-e2e-aws-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit dc891d1 into openshift:main Nov 13, 2024
@openshift-bot
Copy link

openshift-bot commented Nov 14, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-olm-operator
This PR has been included in build ose-cluster-olm-operator-container-v4.19.0-202411140108.p0.gdc891d1.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anik120 anik120 Awaiting requested review from anik120

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@joelanford joelanford

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@perdasilva @openshift-ci-robot @joelanford @thetechnick @tmshort @openshift-bot