Add networking test for invalid external gateway#26883
Add networking test for invalid external gateway#26883openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @pperiyasamy. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
/retest |
|
/test e2e-aws-single-node |
|
/assign @adambkaplan |
adambkaplan
left a comment
adambkaplan
left a comment
There was a problem hiding this comment.
I'm not an expert to approve this - please assign someone from the relevant Networking team.
| It("Should validate failure if an external gateway address does not match the address family of the pod", func() { | ||
| err := createPod(f.ClientSet, f.Namespace.Name, "test-valid-gateway-pod") | ||
| expectNoError(err) | ||
| makeNamespaceWithExternalGatewaySet(f, "fd00:10:244:2::6") |
There was a problem hiding this comment.
Please provide a comment explaining why this IPv6 address is being used.
| "context" | ||
| "time" | ||
|
|
||
| . "github.com/onsi/ginkgo" |
There was a problem hiding this comment.
Ginkgo imports typically have an explicit prefix
| . "github.com/onsi/ginkgo" | |
| g "github.com/onsi/ginkgo" |
This validates pod creation fails when supplying an external gateway address to the namespace that does not match the address family of the pod. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
pperiyasamy
force-pushed
the
invalid-ext-gateway-test
branch
from
d28fa1e to
466706f
Compare
|
/assign @dcbw |
|
/lgtm |
|
/assign @danwinship @msherif1234 @JacobTanenbaum |
|
@adambkaplan Can you please apply the approve label again? It looks like the bot did not catch your last one? Thanks |
|
/refresh |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, dcbw, pperiyasamy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@pperiyasamy: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
7 participants
This validates pod creation fails when supplying an external gateway
address to the namespace that does not match the address family
of the pod.
This PR is continuation of this e2e test (ovn-kubernetes/ovn-kubernetes#1881) in ovn-kubernetes.
Signed-off-by: Periyasamy Palanisamy pepalani@redhat.com