Skip to content

Bug 2033341: tests: skip some tests for proxy#26705

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.9from
EmilienM:bz_2033341
Dec 17, 2021
Merged

Bug 2033341: tests: skip some tests for proxy#26705
openshift-merge-robot merged 1 commit intoopenshift:release-4.9from
EmilienM:bz_2033341

Conversation

@EmilienM
Copy link
Member

Some tests are known to be unstable since they need Internet access and
therefor cause issue when running behind a secured proxy.

Let's skip them for now.

(cherry picked from commit b2d5691)

Some tests are known to be unstable since they need Internet access and
therefor cause issue when running behind a secured proxy.

Let's skip them for now.

(cherry picked from commit b2d5691)
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021

@EmilienM: This pull request references Bugzilla bug 2033341, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2033341: tests: skip some tests for proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021

@EmilienM: This pull request references Bugzilla bug 2033341, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2019375 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2019375 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (emacchi@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

`\[sig-builds\]\[Feature:Builds\] oc new-app should succeed with a --name of 58 characters`,
`\[sig-network\] DNS should resolve DNS of partial qualified names for services`,
`\[sig-arch\] Only known images used by tests`,
`\[sig-network\] DNS should provide DNS for the cluster`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least some of these seem like tests that should work in a proxy environment, has the investigation been done to understand why they are not?

i'm ok w/ disabling them while the investigation is done (via new bugs) but i'm not so sure we should just be disabling them w/o tracking a plan to fix them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bparees I've created a BZ and assigned it to the right team: https://bugzilla.redhat.com/show_bug.cgi?id=2033628
I'll keep an eye and hopefully at some point remove these tests fro that list, so we can exercise them if it makes sense.

Thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi it's probably going to end up needing more than one bug since these tests are owned by different teams

`\[sig-node\] Pods should support remote command execution over websockets`,

// These tests are flacky and require internet access
// See https://bugzilla.redhat.com/show_bug.cgi?id=2019375
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make a note here listing the bugs that are being used to investigate the failures (i.e. the bugs that, when resolved, will allow us to either re-enable these tests, or decide to skip them permanently)?

would be good to have that note in master as well. This is how someone 6 months from now who is digging through this, can follow up on what ended up happening and ensure the tests are properly re-enabled(if they should be).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bparees done via #26710 - do you want me to add it here as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

being done in master here:
#26710

less critical to have it in the z-branch, since it'll eventually carry backwards from master over time and we're unlikely to backport the fixes to re-enable these tests in 4.9.

@bparees bparees added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Dec 17, 2021
@EmilienM
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@EmilienM: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bparees
Copy link
Contributor

bparees commented Dec 17, 2021

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2021
@openshift-merge-robot openshift-merge-robot merged commit 44d1542 into openshift:release-4.9 Dec 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@EmilienM: All pull requests linked via external trackers have merged:

Bugzilla bug 2033341 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2033341: tests: skip some tests for proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants