Bug 2033341: tests: skip some tests for proxy#26705
Bug 2033341: tests: skip some tests for proxy#26705openshift-merge-robot merged 1 commit intoopenshift:release-4.9from EmilienM:bz_2033341
Conversation
Some tests are known to be unstable since they need Internet access and therefor cause issue when running behind a secured proxy. Let's skip them for now. (cherry picked from commit b2d5691)
|
@EmilienM: This pull request references Bugzilla bug 2033341, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@EmilienM: This pull request references Bugzilla bug 2033341, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (emacchi@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| `\[sig-builds\]\[Feature:Builds\] oc new-app should succeed with a --name of 58 characters`, | ||
| `\[sig-network\] DNS should resolve DNS of partial qualified names for services`, | ||
| `\[sig-arch\] Only known images used by tests`, | ||
| `\[sig-network\] DNS should provide DNS for the cluster`, |
There was a problem hiding this comment.
at least some of these seem like tests that should work in a proxy environment, has the investigation been done to understand why they are not?
i'm ok w/ disabling them while the investigation is done (via new bugs) but i'm not so sure we should just be disabling them w/o tracking a plan to fix them.
There was a problem hiding this comment.
@bparees I've created a BZ and assigned it to the right team: https://bugzilla.redhat.com/show_bug.cgi?id=2033628
I'll keep an eye and hopefully at some point remove these tests fro that list, so we can exercise them if it makes sense.
Thanks
There was a problem hiding this comment.
fyi it's probably going to end up needing more than one bug since these tests are owned by different teams
| `\[sig-node\] Pods should support remote command execution over websockets`, | ||
|
|
||
| // These tests are flacky and require internet access | ||
| // See https://bugzilla.redhat.com/show_bug.cgi?id=2019375 |
There was a problem hiding this comment.
can you make a note here listing the bugs that are being used to investigate the failures (i.e. the bugs that, when resolved, will allow us to either re-enable these tests, or decide to skip them permanently)?
would be good to have that note in master as well. This is how someone 6 months from now who is digging through this, can follow up on what ended up happening and ensure the tests are properly re-enabled(if they should be).
There was a problem hiding this comment.
being done in master here:
#26710
less critical to have it in the z-branch, since it'll eventually carry backwards from master over time and we're unlikely to backport the fixes to re-enable these tests in 4.9.
|
/retest |
|
@EmilienM: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@EmilienM: All pull requests linked via external trackers have merged: Bugzilla bug 2033341 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Some tests are known to be unstable since they need Internet access and
therefor cause issue when running behind a secured proxy.
Let's skip them for now.
(cherry picked from commit b2d5691)