-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Bug 2033341: tests: skip some tests for proxy #26705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -94,6 +94,14 @@ var ( | |
| `\[sig-cli\] Kubectl Port forwarding With a server listening on localhost should support forwarding over websockets`, | ||
| `\[sig-cli\] Kubectl Port forwarding With a server listening on 0.0.0.0 should support forwarding over websockets`, | ||
| `\[sig-node\] Pods should support remote command execution over websockets`, | ||
|
|
||
| // These tests are flacky and require internet access | ||
| // See https://bugzilla.redhat.com/show_bug.cgi?id=2019375 | ||
| `\[sig-builds\]\[Feature:Builds\] build can reference a cluster service with a build being created from new-build should be able to run a build that references a cluster service`, | ||
| `\[sig-builds\]\[Feature:Builds\] oc new-app should succeed with a --name of 58 characters`, | ||
| `\[sig-network\] DNS should resolve DNS of partial qualified names for services`, | ||
| `\[sig-arch\] Only known images used by tests`, | ||
| `\[sig-network\] DNS should provide DNS for the cluster`, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. at least some of these seem like tests that should work in a proxy environment, has the investigation been done to understand why they are not? i'm ok w/ disabling them while the investigation is done (via new bugs) but i'm not so sure we should just be disabling them w/o tracking a plan to fix them.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bparees I've created a BZ and assigned it to the right team: https://bugzilla.redhat.com/show_bug.cgi?id=2033628 Thanks
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fyi it's probably going to end up needing more than one bug since these tests are owned by different teams |
||
| }, | ||
| "[Skipped:SingleReplicaTopology]": { | ||
| `\[sig-apps\] Daemon set \[Serial\] should rollback without unnecessary restarts \[Conformance\]`, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make a note here listing the bugs that are being used to investigate the failures (i.e. the bugs that, when resolved, will allow us to either re-enable these tests, or decide to skip them permanently)?
would be good to have that note in master as well. This is how someone 6 months from now who is digging through this, can follow up on what ended up happening and ensure the tests are properly re-enabled(if they should be).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bparees done via #26710 - do you want me to add it here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
being done in master here:
#26710
less critical to have it in the z-branch, since it'll eventually carry backwards from master over time and we're unlikely to backport the fixes to re-enable these tests in 4.9.