Skip to content

Bug 2033341: [release-4.9] test: skip tests that won't work behind a proxy automatically#26664

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.9from
openshift-cherrypick-robot:cherry-pick-26398-to-release-4.9
Dec 16, 2021
Merged

Bug 2033341: [release-4.9] test: skip tests that won't work behind a proxy automatically#26664
openshift-merge-robot merged 1 commit intoopenshift:release-4.9from
openshift-cherrypick-robot:cherry-pick-26398-to-release-4.9

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 3, 2021

This is an automated cherry-pick of #26398

/assign mandre

@stbenjam
test: skip tests that won't work behind a proxy automatically
464f53f 
The vast majority of the tests we run work and run fine through
an HTTP proxy to reach the target cluster under test, however a
handful of tests don't work. This adds a configuration to
openshift-tests to see if given the current proxy environment, we
would use a proxy to reach the API server. If so, then we skip
tests annotated with `[Skip:Proxy]`.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 3, 2021
Merged
@mandre
Copy link
Member

mandre commented Dec 3, 2021

/retest

@EmilienM EmilienM mentioned this pull request Dec 3, 2021
Merged
@mandre
Copy link
Member

mandre commented Dec 3, 2021

/retest

@EmilienM
Copy link
Member

EmilienM commented Dec 3, 2021

/lgtm

@EmilienM
Copy link
Member

EmilienM commented Dec 3, 2021 •
edited
Loading

/assign dmage

@EmilienM
Copy link
Member

EmilienM commented Dec 3, 2021

ping @dmage for a review; Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2021
@dmage
Copy link
Contributor

dmage commented Dec 14, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, EmilienM, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2021
@EmilienM
Copy link
Member

EmilienM commented Dec 14, 2021

@stbenjam do you know if I need a BZ for this one to be able to merge?
The original patch on master didn't have a BZ.
Let me know how we can proceed.

Thanks

@EmilienM
Copy link
Member

EmilienM commented Dec 16, 2021

/retitle Bug 2033341: [release-4.9] test: skip tests that won't work behind a proxy automatically

@openshift-ci openshift-ci bot changed the title [release-4.9] test: skip tests that won't work behind a proxy automatically Bug 2033341: [release-4.9] test: skip tests that won't work behind a proxy automatically Dec 16, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2033341, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2019375 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2019375 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (emacchi@redhat.com), skipping review request.

Details

In response to this:

Bug 2033341: [release-4.9] test: skip tests that won't work behind a proxy automatically

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees bparees added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Dec 16, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f2b0d05 into openshift:release-4.9 Dec 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2033341 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2033341: [release-4.9] test: skip tests that won't work behind a proxy automatically

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Dec 17, 2021
Merged
@ardaguclu ardaguclu mentioned this pull request Jan 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmage dmage Awaiting requested review from dmage

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@mandre mandre

@stbenjam stbenjam

@EmilienM EmilienM

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @mandre @EmilienM @dmage @openshift-bot @stbenjam @bparees @openshift-merge-robot