Skip to content

Comments

[release-4.8] Bug 1975938: Fix skipping of Multi-AZ Cluster Volumes test on GCP with k8s 1.21#26267

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-4.8from
yselkowitz:bz1975938
Jul 3, 2021
Merged

[release-4.8] Bug 1975938: Fix skipping of Multi-AZ Cluster Volumes test on GCP with k8s 1.21#26267
openshift-merge-robot merged 2 commits intoopenshift:release-4.8from
yselkowitz:bz1975938

Conversation

@yselkowitz
Copy link
Contributor

Backport of #26264 for 4.8.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

@yselkowitz: This pull request references Bugzilla bug 1975938, which is invalid:

  • expected dependent Bugzilla bug 1975283 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.8] Bug 1975938: Fix skipping of Multi-AZ Cluster Volumes test on GCP with k8s 1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@yselkowitz
Copy link
Contributor Author

/test all

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jun 24, 2021
@yselkowitz
Copy link
Contributor Author

/bugzilla refresh
/retest

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@yselkowitz: This pull request references Bugzilla bug 1975938, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1975283 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1975283 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 25, 2021
In order to update the Multi-AZ Cluster Volumes test which was renamed
in k8s 1.21:

openshift/kubernetes#829
In order to update the Multi-AZ Cluster Volumes test which was renamed
in k8s 1.21:

openshift/kubernetes#829
@yselkowitz yselkowitz marked this pull request as ready for review June 29, 2021 18:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2021
k8s.io/sample-apiserver => github.com/openshift/kubernetes/staging/src/k8s.io/sample-apiserver v0.0.0-20210603185452-2dfc46b23003
k8s.io/sample-cli-plugin => github.com/openshift/kubernetes/staging/src/k8s.io/sample-cli-plugin v0.0.0-20210603185452-2dfc46b23003
k8s.io/sample-controller => github.com/openshift/kubernetes/staging/src/k8s.io/sample-controller v0.0.0-20210603185452-2dfc46b23003
github.com/opencontainers/runc => github.com/openshift/opencontainers-runc v1.0.0-rc95.0.20210608002938-1f5126fe967e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment like this? This helps for next person doing k8s bumps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is a stable branch, do you anticipate openshift/kubernetes reverting to upstream runc for the duration of 4.8? Perhaps master, where this is much more likely, would be a better place for such a comment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might do minor bumps for 4.8 as well, so better to add it for both master and 4.8 branches.

@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

Besides the builds/jenkins failures which are being worked on, is 4.8 CI just that bad right now or is there a real issue here?

@ravisantoshgudimetla
Copy link
Contributor

/retest

The proxy seems to have unrelated issue. Can you fix #26267 (comment)?

@bparees
Copy link
Contributor

bparees commented Jun 30, 2021

proxy and metal-ipi-ovn both seem to be generally broken, we can override those if/when you get green elsewhere and have lgtm/approval

@yselkowitz
Copy link
Contributor Author

/retest

1 similar comment
@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

/test e2e-gcp-builds

@yselkowitz
Copy link
Contributor Author

All tests are green except for those known to be broken.

@jsafrane
Copy link
Contributor

jsafrane commented Jul 2, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2021
@sttts
Copy link
Contributor

sttts commented Jul 2, 2021

/retest
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, sttts, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2021
@yselkowitz
Copy link
Contributor Author

We're ready for those overrides now.
/assign @bparees

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees
Copy link
Contributor

bparees commented Jul 2, 2021

/override ci/prow/e2e-aws-proxy
/override ci/prow/e2e-metal-ipi

discussing group lead approval with @mfojtik and @sttts on slack

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-aws-proxy, ci/prow/e2e-metal-ipi

Details

In response to this:

/override ci/prow/e2e-aws-proxy
/override ci/prow/e2e-metal-ipi

discussing group lead approval with @mfojtik and @sttts on slack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees bparees added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jul 2, 2021
@bparees
Copy link
Contributor

bparees commented Jul 2, 2021

/override ci/prow/e2e-aws-proxy
/override ci/prow/e2e-metal-ipi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-aws-proxy, ci/prow/e2e-metal-ipi

Details

In response to this:

/override ci/prow/e2e-aws-proxy
/override ci/prow/e2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yselkowitz
Copy link
Contributor Author

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2021

@yselkowitz: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-jenkins 985584a link /test e2e-aws-jenkins

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5b063e6 into openshift:release-4.8 Jul 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2021

@yselkowitz: All pull requests linked via external trackers have merged:

Bugzilla bug 1975938 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.8] Bug 1975938: Fix skipping of Multi-AZ Cluster Volumes test on GCP with k8s 1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yselkowitz yselkowitz deleted the bz1975938 branch October 5, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants