Skip to content

Comments

Bug 1975938: Bump k8s to get latest tests#26286

Closed
ravisantoshgudimetla wants to merge 2 commits intoopenshift:release-4.8from
ravisantoshgudimetla:release-4.8
Closed

Bug 1975938: Bump k8s to get latest tests#26286
ravisantoshgudimetla wants to merge 2 commits intoopenshift:release-4.8from
ravisantoshgudimetla:release-4.8

Conversation

@ravisantoshgudimetla
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla commented Jun 29, 2021

Bump k8s to get latest 1.21 tests

xref: openshift/kubernetes#829

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2021

@ravisantoshgudimetla: This pull request references Bugzilla bug 1975938, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1975283 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1975283 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

Details

In response to this:

Bug 1975938: Bump k8s to get latest tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ravisantoshgudimetla
To complete the pull request process, please assign sjenning after the PR has been reviewed.
You can assign the PR to them by writing /assign @sjenning in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jun 29, 2021
@openshift-ci openshift-ci bot requested review from deads2k and smarterclayton June 29, 2021 20:21
ravisantoshgudimetla
ravisantoshgudimetla commented Jun 29, 2021
View reviewed changes
go.mod
k8s.io/sample-apiserver => github.com/openshift/kubernetes/staging/src/k8s.io/sample-apiserver v0.0.0-20210603185452-2dfc46b23003
k8s.io/sample-cli-plugin => github.com/openshift/kubernetes/staging/src/k8s.io/sample-cli-plugin v0.0.0-20210603185452-2dfc46b23003
k8s.io/sample-controller => github.com/openshift/kubernetes/staging/src/k8s.io/sample-controller v0.0.0-20210603185452-2dfc46b23003
// This needs to be removed when https://github.com/kubernetes/kubernetes/issues/102676 is backedported to 1.21
Copy link
Contributor Author

@ravisantoshgudimetla ravisantoshgudimetla Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soltysh - something to keep in mind when rebasing 4.8 in future.

@yselkowitz
Copy link
Contributor

yselkowitz commented Jun 29, 2021

#26267 already exists for this purpose.

@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Jun 29, 2021

/close

@yselkowitz - Apologies, did not notice that you already have a PR opened. I am closing this one but please add a comment to go.mod which mentions something like ^

@openshift-ci openshift-ci bot closed this Jun 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2021

@ravisantoshgudimetla: Closed this PR.

Details

In response to this:

/close

@yselkowitz - Apologies, did not notice that you already have a PR opened. I am closing this one but please add a comment to go.mod which mentions something like ^

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2021

@ravisantoshgudimetla: This pull request references Bugzilla bug 1975938. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1975938: Bump k8s to get latest tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

No one assigned

Labels

bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ravisantoshgudimetla @yselkowitz