Skip to content

Comments

Bug 1975283: Fix skipping of Multi-AZ Cluster Volumes test on GCP with k8s 1.21#26264

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
yselkowitz:bz1975283
Jun 25, 2021
Merged

Bug 1975283: Fix skipping of Multi-AZ Cluster Volumes test on GCP with k8s 1.21#26264
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
yselkowitz:bz1975283

Conversation

@yselkowitz
Copy link
Contributor

@yselkowitz yselkowitz commented Jun 23, 2021

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

@yselkowitz: This pull request references Bugzilla bug 1975283, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

Details

In response to this:

Bug 1975283: Fix skipping of Multi-AZ Cluster Volumes test on GCP with k8s 1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@yselkowitz
Copy link
Contributor Author

yselkowitz commented Jun 23, 2021

To confirm that this will actually work
/test e2e-gcp

@yselkowitz yselkowitz mentioned this pull request Jun 23, 2021
Merged
@openshift-ci openshift-ci bot requested review from bparees and deads2k June 23, 2021 21:05
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jun 23, 2021
@yselkowitz
Copy link
Contributor Author

yselkowitz commented Jun 23, 2021

Forgot to make update.
/test all

@yselkowitz
Copy link
Contributor Author

yselkowitz commented Jun 23, 2021

/test all

@yselkowitz yselkowitz mentioned this pull request Jun 24, 2021
Merged
This was referenced Jun 24, 2021
Merged
Merged
Merged
@yselkowitz
Copy link
Contributor Author

yselkowitz commented Jun 24, 2021

Ultimately, I guess this needs to turn into (or be replaced by) a revendoring of kubernetes in origin (after openshift/kubernetes#825 merges) to fix this properly? If so, as a non-maintainer, that's a bit out of my scope.

@yselkowitz
Copy link
Contributor Author

yselkowitz commented Jun 24, 2021

/test e2e-agnostic-cmd

@marun
Copy link
Contributor

marun commented Jun 24, 2021 •
edited
Loading

Ultimately, I guess this needs to turn into (or be replaced by) a revendoring of kubernetes in origin (after openshift/kubernetes#825 merges) to fix this properly? If so, as a non-maintainer, that's a bit out of my scope.

See the following section in the README regarding the steps to take to revendor o/k: https://github.com/openshift/origin/blob/master/README.md#vendoring-from-openshiftkubernetes

@yselkowitz
Bump(github.com/openshift/kubernetes)
f8a1806 
In order to update the Multi-AZ Cluster Volumes test which was renamed
in k8s 1.21:

openshift/kubernetes#825
@yselkowitz
Regenerate annotations
a791df0 
In order to update the Multi-AZ Cluster Volumes test which was renamed
in k8s 1.21:

openshift/kubernetes#825
@yselkowitz yselkowitz marked this pull request as ready for review June 24, 2021 20:44
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2021
@yselkowitz yselkowitz mentioned this pull request Jun 24, 2021
Merged
@yselkowitz
Copy link
Contributor Author

yselkowitz commented Jun 25, 2021

/retest

@yselkowitz
Copy link
Contributor Author

yselkowitz commented Jun 25, 2021

This is my first revendoring of kubernetes. While it pulls in much more than needed for this purpose, that is apparently the expected approach, and does fix the e2e-gcp test which is currently broken.
/assign @deads2k

@yselkowitz
Copy link
Contributor Author

yselkowitz commented Jun 25, 2021

Remaining test failure appears to be an existing issue: https://bugzilla.redhat.com/show_bug.cgi?id=1975865

yselkowitz
yselkowitz commented Jun 25, 2021
View reviewed changes
test/extended/util/annotate/generated/zz_generated.annotations.go
"[Top Level] [sig-storage] Mounted volume expand Should verify mounted devices can be resized": "Should verify mounted devices can be resized [Suite:openshift/conformance/parallel] [Suite:k8s]",

"[Top Level] [sig-storage] Multi-AZ Cluster Volumes should only be allowed to provision PDs in zones where nodes exist": "should only be allowed to provision PDs in zones where nodes exist [Suite:openshift/conformance/parallel] [Suite:k8s]",
"[Top Level] [sig-storage] Multi-AZ Cluster Volumes should only be allowed to provision PDs in zones where nodes exist": "should only be allowed to provision PDs in zones where nodes exist [Skipped:gce] [Suite:openshift/conformance/parallel] [Suite:k8s]",
Copy link
Contributor Author

@yselkowitz yselkowitz Jun 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is the key part in this PR.

@deads2k
Copy link
Contributor

deads2k commented Jun 25, 2021

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2021
@stbenjam
Copy link
Member

stbenjam commented Jun 25, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, stbenjam, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 25, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@yselkowitz
Copy link
Contributor Author

yselkowitz commented Jun 25, 2021

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 25, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@yselkowitz yselkowitz mentioned this pull request Jun 25, 2021
Closed
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 25, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 25, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@danwinship
Copy link
Contributor

danwinship commented Jun 25, 2021

FTR, e2e-metal-ipi-ovn-ipv6 is failing because of things which will be fixed by #26266 except that that PR can't merge because it's failing on e2e-gcp because of the Multi-AZ Cluster Volumes test.

So, like, someone should /override ci/prow/e2e-metal-ipi-ovn-ipv6

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 25, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@yselkowitz
Copy link
Contributor Author

yselkowitz commented Jun 25, 2021

Jenkins is unrelated and being worked: #26268
e2e-metal-ipi-ovn-ipv6 is unrelated and waiting on this: #26266
At this point we need an override to unblock GCP tests
/assign @bparees

@bparees
Copy link
Contributor

bparees commented Jun 25, 2021

/override ci/prow/e2e-aws-jenkins
/override ci/prow/e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-aws-jenkins, ci/prow/e2e-metal-ipi-ovn-ipv6

Details

In response to this:

/override ci/prow/e2e-aws-jenkins
/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 8afb243 into openshift:master Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@yselkowitz: All pull requests linked via external trackers have merged:

Bugzilla bug 1975283 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1975283: Fix skipping of Multi-AZ Cluster Volumes test on GCP with k8s 1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yselkowitz yselkowitz deleted the bz1975283 branch June 25, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@stbenjam stbenjam

@bparees bparees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@yselkowitz @marun @deads2k @stbenjam @openshift-bot @danwinship @bparees @openshift-merge-robot