Skip to content

Comments

Bug 1975283: update Multi-AZ Cluster Volumes test name#825

Merged
deads2k merged 1 commit intoopenshift:masterfrom
multi-arch:bz1975283
Jun 24, 2021
Merged

Bug 1975283: update Multi-AZ Cluster Volumes test name#825
deads2k merged 1 commit intoopenshift:masterfrom
multi-arch:bz1975283

Conversation

@yselkowitz
Copy link

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

This test was renamed upstream in
kubernetes@006dc74

4.9 GCP tests are now failing because this is no longer being skipped.

Which issue(s) this PR fixes:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1975283

Special notes for your reviewer:

This will have to be vendored into origin to fix the tests.

Does this PR introduce a user-facing change?

NONE

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 23, 2021
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 23, 2021
@openshift-ci openshift-ci bot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Jun 23, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2021

@yselkowitz: This pull request references Bugzilla bug 1975283, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1975283: update Multi-AZ Cluster Volumes test name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 23, 2021
@openshift-ci-robot
Copy link

@yselkowitz: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@yselkowitz
Copy link
Author

/bugzilla refresh

@openshift-ci openshift-ci bot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jun 23, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2021

@yselkowitz: This pull request references Bugzilla bug 1975283, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jun 23, 2021
@openshift-ci openshift-ci bot requested review from soltysh and sttts June 23, 2021 20:54
@yselkowitz
Copy link
Author

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2021

@yselkowitz: This pull request references Bugzilla bug 1975283, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@yselkowitz: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@yselkowitz
Copy link
Author

Testing on openshift/origin#26264 seems to indicate that when this change is vendored into origin (and make update is run), that fixes the e2e-gcp test job which is currently failing product-wide.
/assign @marun

@jsafrane
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@yselkowitz
Copy link
Author

A backport to 4.8 has been requested: https://bugzilla.redhat.com/show_bug.cgi?id=1975283#c4
/cherry-pick release-4.8

@openshift-cherrypick-robot

@yselkowitz: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you.

Details

In response to this:

A backport to 4.8 has been requested: https://bugzilla.redhat.com/show_bug.cgi?id=1975283#c4
/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton
Copy link

/approve
/retest

@deads2k deads2k removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 24, 2021
@deads2k
Copy link

deads2k commented Jun 24, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jsafrane, smarterclayton, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2021

@yselkowitz: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 5a0753f link /test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yselkowitz
Copy link
Author

Does e2e-gcp here depend on this being fixed (via revendoring) in origin (as pretested via openshift/origin#26264) or does the failure here indicate that the patch does not actually suffice?

@marun
Copy link

marun commented Jun 24, 2021

Does e2e-gcp here depend on this being fixed (via revendoring) in origin (as pretested via openshift/origin#26264) or does the failure here indicate that the patch does not actually suffice?

e2e-gcp uses openshift-tests, which is built out of origin. Only the k8s-e2e-* jobs use tests built from this repo (i.e. reflect the changes in this PR).

I'm curious how a skip-bypassing test rename was able to merge. Is the test in question flakey rather than failing consistently? cc: @soltysh

There are 2 paths to resolving this:

  • Given that only the test intended to be skipped is failing:
    • Get someone with sufficient authority to skip e2e-gcp so that this PR can merge
    • Vendor the change into origin via origin#26264

or

  • If skipping e2e-gcp isn't an option:
    • merge a skip directive to origin's rules so that e2e-gcp is capable of passing on this PR
    • merge this PR
    • vendor the change into origin and remove the skip from origin's rules

@deads2k deads2k merged commit c6914a8 into openshift:master Jun 24, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2021

@yselkowitz: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1975283 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1975283: update Multi-AZ Cluster Volumes test name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@yselkowitz: new pull request created: #829

Details

In response to this:

A backport to 4.8 has been requested: https://bugzilla.redhat.com/show_bug.cgi?id=1975283#c4
/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yselkowitz added a commit to yselkowitz/origin that referenced this pull request Jun 24, 2021
In order to update the Multi-AZ Cluster Volumes test which was renamed
in k8s 1.21:

openshift/kubernetes#825
yselkowitz added a commit to yselkowitz/origin that referenced this pull request Jun 24, 2021
In order to update the Multi-AZ Cluster Volumes test which was renamed
in k8s 1.21:

openshift/kubernetes#825
@yselkowitz yselkowitz deleted the bz1975283 branch June 24, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants