release-3.11: Revert code to address issue with missing python-ipaddress module

[mtnbikenc]

The rearrangement of tasks in #12268 set off a string of changes required due to the intertwined nature of openshift-ansible playbooks. Follow-up PRs were required to address issues in CI and upgrades. In order to address the latest issue of openshift_facts being run prior to the python-ipaddress package being installed, it was going to require even further rearrangement of playbooks which could lead to additional PRs to fix other issues. This PR reverts the PRs below to get back to the original code flow. The final commit ensures master facts are set on all hosts prior to running the certificates playbooks for masters, where during scaleup, only one master would be in scope for the playbook.

Reverts the following:
#12268 Bug 1777061: playbooks/init: Refresh master facts during init
#12270 playbooks/init: Fix GCP job when oo_masters is not defined
#12307 Bug 1921353: [release-3.11] Gather cluster_facts after version.yml during upgrade
#12310 Bug 1933090: Move node fact initialization to basic_facts.yml

[openshift-ci-robot]

@mtnbikenc: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Revert move of 'Initialize openshift.node.sdn_mtu'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mtnbikenc]

Requires #12324

[mtnbikenc]

/test e2e-gcp

[openshift-ci-robot]

@mtnbikenc: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

release-3.11: Revert move of 'Initialize openshift.node.sdn_mtu'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jstuever]

/assign

[jstuever]

/lgtm

[jstuever]

/hold for #12324

[jstuever]

/assign @mtnbikenc

[mtnbikenc]

/retest

[mtnbikenc]

#12324 is merged
/hold cancel

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@mtnbikenc: Overrode contexts on behalf of mtnbikenc: ci/prow/e2e-aws

Details

In response to this:

e2e-aws job failed as expected. Fixed by openshift/origin#26070 which requires this PR to deploy the cluster.

/override ci/prow/e2e-aws

INFO[2021-04-20T18:41:46Z] Summarizing 1 Failure:                       
INFO[2021-04-20T18:41:46Z]                                              
INFO[2021-04-20T18:41:46Z] [Fail] [Feature:Builds][Conformance] build without output image  building from templates [It] should create an image from a docker template without an output image reference defined [Suite:openshift/conformance/parallel/minimal] 

Waiting for e2e-gcp to ensure it deploys the cluster and reaches e2e tests.
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mtnbikenc]

/test e2e-gcp

[mtnbikenc]

/test e2e-gcp

[mtnbikenc]

e2e-gcp is broken in more ways than I can investigate at this time. This PR should be good to go at this point to at least be able to get e2e-aws functional with the origin PR.

/assign @jstuever

[mtnbikenc]

/test e2e-gcp

[mtnbikenc]

Install completed for e2e-aws.
Install completed for e2e-gcp, with the revert to old gcloud.

[mtnbikenc]

/hold cancel

[mtnbikenc]

/uncc @jcpowermac
/cc @jstuever

[jstuever]

/lgtm

[jstuever]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, mtnbikenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jstuever,mtnbikenc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[mtnbikenc]

Needs openshift/origin#26070
/override ci/prow/e2e-aws

�[36mINFO�[0m[2021-04-22T10:51:09Z] Summarizing 1 Failure:                       
�[36mINFO�[0m[2021-04-22T10:51:09Z]                                              
�[36mINFO�[0m[2021-04-22T10:51:09Z] [Fail] [Feature:Builds][Conformance] build without output image  building from templates [It] should create an image from a docker template without an output image reference defined [Suite:openshift/conformance/parallel/minimal]  
�[36mINFO�[0m[2021-04-22T10:51:09Z] /tmp/openshift/build-rpms/rpm/BUILD/origin-3.11.0/_output/local/go/src/github.com/openshift/origin/test/extended/builds/no_outputname.go:40 

[openshift-ci-robot]

@mtnbikenc: Overrode contexts on behalf of mtnbikenc: ci/prow/e2e-aws

Details

In response to this:

Needs openshift/origin#26070
/override ci/prow/e2e-aws

�[36mINFO�[0m[2021-04-22T10:51:09Z] Summarizing 1 Failure:                       
�[36mINFO�[0m[2021-04-22T10:51:09Z]                                              
�[36mINFO�[0m[2021-04-22T10:51:09Z] [Fail] [Feature:Builds][Conformance] build without output image  building from templates [It] should create an image from a docker template without an output image reference defined [Suite:openshift/conformance/parallel/minimal]  
�[36mINFO�[0m[2021-04-22T10:51:09Z] /tmp/openshift/build-rpms/rpm/BUILD/origin-3.11.0/_output/local/go/src/github.com/openshift/origin/test/extended/builds/no_outputname.go:40 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mtnbikenc]

/override ci/prow/e2e-gcp

[openshift-ci-robot]

@mtnbikenc: Overrode contexts on behalf of mtnbikenc: ci/prow/e2e-gcp

Details

In response to this:

/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.