Skip to content

Comments

Bug 1957193: Add tests required internet into Skipped:Disconnected list#26051

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ardaguclu:add-tests-skipped-disconnected
Jul 28, 2021
Merged

Bug 1957193: Add tests required internet into Skipped:Disconnected list#26051
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ardaguclu:add-tests-skipped-disconnected

Conversation

@ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented Apr 7, 2021

This PR adds tests, required internet access and fails in disconnected environment, into the [Skipped:Disconnected] list.

@ardaguclu ardaguclu force-pushed the add-tests-skipped-disconnected branch from 63e46cc to cc41ac1 Compare April 7, 2021 06:06
@ardaguclu
Copy link
Member Author

/test verify

@ardaguclu ardaguclu force-pushed the add-tests-skipped-disconnected branch 2 times, most recently from 4f92d48 to 1e6d65a Compare April 7, 2021 07:26
@ardaguclu
Copy link
Member Author

/retest

4 similar comments
@ardaguclu
Copy link
Member Author

/retest

@ardaguclu
Copy link
Member Author

/retest

@ardaguclu
Copy link
Member Author

/retest

@ardaguclu
Copy link
Member Author

/retest

@ardaguclu
Copy link
Member Author

/test e2e-gcp-upgrade

3 similar comments
@ardaguclu
Copy link
Member Author

/test e2e-gcp-upgrade

@ardaguclu
Copy link
Member Author

/test e2e-gcp-upgrade

@ardaguclu
Copy link
Member Author

/test e2e-gcp-upgrade

@ardaguclu
Copy link
Member Author

/assign @derekwaynecarr @smarterclayton

@stbenjam
Copy link
Member

stbenjam commented Apr 22, 2021

Can you add \[sig-network\] Networking should provide Internet connection for containers to this and I can close https://github.com/openshift/origin/pull/26050/files?

@ardaguclu ardaguclu force-pushed the add-tests-skipped-disconnected branch from 1e6d65a to 33eb5f2 Compare April 22, 2021 12:53
@ardaguclu
Copy link
Member Author

/test e2e-aws-csi

@ardaguclu
Copy link
Member Author

/test e2e-gcp-csi

@ardaguclu
Copy link
Member Author

/test e2e-aws-csi

@ardaguclu
Copy link
Member Author

/test e2e-aws-serial

@ardaguclu
Copy link
Member Author

/retest

2 similar comments
@ardaguclu
Copy link
Member Author

/retest

@ardaguclu
Copy link
Member Author

/retest

@ardaguclu
Copy link
Member Author

/test e2e-agnostic-cmd

@ardaguclu
Copy link
Member Author

/test e2e-aws-csi

@ardaguclu
Copy link
Member Author

/test e2e-gcp-disruptive

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@ardaguclu
Copy link
Member Author

/retest-required

@ardaguclu
Copy link
Member Author

/test e2e-metal-ipi-ovn-ipv6

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2021
@ardaguclu ardaguclu force-pushed the add-tests-skipped-disconnected branch from 6108995 to 6e569d3 Compare July 28, 2021 05:18
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 28, 2021
@ardaguclu
Copy link
Member Author

/test e2e-gcp

@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, danwinship, knobunc, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-disruptive 416bce1 link /test e2e-aws-disruptive
ci/prow/e2e-gcp-disruptive 416bce1 link /test e2e-gcp-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ardaguclu
Copy link
Member Author

/test e2e-metal-ipi-ovn-ipv6

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d09d92f into openshift:master Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@ardaguclu: All pull requests linked via external trackers have merged:

Bugzilla bug 1957193 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1957193: Add tests required internet into Skipped:Disconnected list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu
Copy link
Member Author

/cherrypick release-4.8

@openshift-cherrypick-robot

@ardaguclu: #26051 failed to apply on top of branch "release-4.8":

Applying: Add tests required internet into Skipped:Disconnected list
Using index info to reconstruct a base tree...
M	test/extended/util/annotate/generated/zz_generated.annotations.go
M	test/extended/util/annotate/rules.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/util/annotate/rules.go
CONFLICT (content): Merge conflict in test/extended/util/annotate/rules.go
Auto-merging test/extended/util/annotate/generated/zz_generated.annotations.go
CONFLICT (content): Merge conflict in test/extended/util/annotate/generated/zz_generated.annotations.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add tests required internet into Skipped:Disconnected list
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.