Bug 1919453: Update to latest 4.7 state where possible

[smarterclayton]

Update all tests to be accurate to 4.7 state, except where obvious
conflicts exist.

[openshift-ci-robot]

@smarterclayton: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

tests: Update to latest 4.7 state where possible

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@smarterclayton: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

DO NOT MERGE: Update to latest 4.7 state where possible

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[smarterclayton]

Depends on openshift/kubernetes#536

[smarterclayton]

@deads2k @gabemontero this is a reset of 4.6 tests code to 4.7 state, removing any backports that were due to changes in kube code packages (maybe 3-4 of those), and then the last commit is places where code compiled but the 4.7 code doesn't pass, so i reverted those as separate commits. Would squash before merging, but this was all selective reversion to the 4.6 state.

If you check this branch out, it's easiest to review

git diff HEAD..origin/master -- 'test/**/*.go'

which shows you all deliberate code differences between this branch and master (deleted lines are 4.6, master is green, so anything in green is something that doesn't pass on 4.6)

The changes most reverted are:

• explain (because types had specs added in 4.7)
• the observe test (flaky in 4.7)
• policy rbac diff (changes to policy were explicit)
• dr changes (since the DR script I think was improved, also depended on code changes in 4.7 kube)

[gabemontero]

fwiw @smarterclayton after both git diff HEAD..origin/master -- 'test/**/*.go', and git diff HEAD..origin/master -- 'test/**/*.json' I saw nothing amiss with what is there, though I admittedly looked closer at the e2e's I'm more familiar with.

I also confirmed my add on after your initial 4.7 drop is there, adding the s2iroot image to the disconnected inventory

Lastly, some test/cmd/build.sh stuff got missed in your initial 4.7 drop as well. I covered those in 4.7 with #25798 and 4.6 with #25805 ... that said I see several other test/extended/testdata/cmd/test/cmd hits in this PR, including moves from docker.io (or implied docker.io) refs to imagestream refs. So my assumption is your searches etc. caught all those type items... you at least were on the look out.

[openshift-ci-robot]

@smarterclayton: This pull request references Bugzilla bug 1919453, which is invalid:

• expected dependent Bugzilla bug 1816812 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1919453: Update to latest 4.7 state where possible

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[smarterclayton]

Getting close to updating this again, now that a bunch of 4.7 fixes have gone in.

[smarterclayton]

/test e2e-agnostic-cmd

[smarterclayton]

/retest

[smarterclayton]

/retest

[smarterclayton]

/bugzilla refresh

[openshift-ci-robot]

@smarterclayton: This pull request references Bugzilla bug 1919453, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1816812 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1816812 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[smarterclayton]

/retest

[smarterclayton]

/test e2e-gcp-builds

[smarterclayton]

/retest

[smarterclayton]

/retest

[openshift-ci]

@smarterclayton: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/artifacts	5ae5749	link	/test artifacts
ci/prow/e2e-gcp-upgrade	5ae5749	link	/test e2e-gcp-upgrade
ci/prow/e2e-aws-upgrade	5ae5749	link	/test e2e-aws-upgrade
ci/prow/e2e-agnostic-cmd	5ae5749	link	/test e2e-agnostic-cmd
ci/prow/e2e-aws-fips	5ae5749	link	/test e2e-aws-fips
ci/prow/e2e-gcp	5ae5749	link	/test e2e-gcp
ci/prow/e2e-gcp-image-ecosystem	5ae5749	link	/test e2e-gcp-image-ecosystem
ci/prow/e2e-gcp-builds	5ae5749	link	/test e2e-gcp-builds
ci/prow/e2e-aws-jenkins	5ae5749	link	/test e2e-aws-jenkins

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@smarterclayton: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@smarterclayton: This pull request references Bugzilla bug 1919453. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1919453: Update to latest 4.7 state where possible

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.