Bug 1915907: replace test/cmd/builds.sh direct/indirect docker.io refs with imagestream image refs #25798

gabemontero · 2021-01-14T16:50:35Z

note at least some of these files were touched by clayton's huge refactor, but a few refs slipped the cracks

/assign @bparees
(in Adam's absence)

thanks @dmage for the heads up

openshift-ci-robot · 2021-01-14T16:50:42Z

@gabemontero: This pull request references Bugzilla bug 1915907, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1915907: remove more docker.io ref escapee from build e2e's

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2021-01-14T16:51:42Z

/bugzilla refresh

openshift-ci-robot · 2021-01-14T16:51:47Z

@gabemontero: This pull request references Bugzilla bug 1915907, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2021-01-14T16:56:33Z

moves in the right direction, so
/lgtm

but ultimately don't we want these refs to all be substituted so the tests can work in a disconnected env too?

gabemontero · 2021-01-14T17:01:21Z

moves in the right direction, so
/lgtm

but ultimately don't we want these refs to all be substituted so the tests can work in a disconnected env too?

Yes we do, and it occurred to me, but I was initially worried if permissions to pull from the internal image registry directly were available to these cmd tests.

That said, I've since found some of those refs so presumably they worked before.

So I'll

/hold

for this for now and inspect the test results. Assuming those internal image registry refs are in fact successfully used, I'll go back and change this along those lines.

thanks @bparees

gabemontero · 2021-01-14T22:44:32Z

the tools IS does not have git

looks like the tests one does ... switching to that

xiuwang · 2021-01-15T07:53:10Z

test/extended/testdata/bindata.go

 # Build from Dockerfile with output to ImageStreamTag
-os::cmd::expect_success "oc new-build --dockerfile=\$'FROM centos:7\nRUN yum install -y httpd'"
-os::cmd::expect_success_and_text "oc get bc/centos --template '${template}'" '^ImageStreamTag centos:latest$'
+os::cmd::expect_success "oc new-build --to=tests:custom--dockerfile=\$'FROM image-registry.openshift-image-registry.svc:5000/openshift/tests:latest\nRUN yum install -y httpd'"


no space between two options --to=tests:custom--dockerfile

gabemontero · 2021-01-15T17:55:09Z

OK agnostic CMD is now passing ! Think I've replace docker.io refs with imagestream docker refs

also should run

/test e2e-aws-builds
/test e2e-gcp-builds

in case those changed json's are used in the builds e2e's

gabemontero · 2021-01-15T21:03:09Z

hit the situation cited in slack announce-testplatform with first e2e-gcp-builds run ... retrying per directions there

/test e2e-gcp-builds

gabemontero · 2021-01-16T00:11:43Z

ok builds passes too ... squashing commit and releasing hold

…tream image refs

gabemontero · 2021-01-16T00:14:59Z

/hold cancel

ready for re-review @bparees

bparees · 2021-01-16T00:38:42Z

/lgtm

openshift-ci-robot · 2021-01-16T00:39:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-01-16T02:02:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-01-16T03:40:53Z

@gabemontero: All pull requests linked via external trackers have merged:

openshift/origin#25798

Bugzilla bug 1915907 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1915907: replace test/cmd/builds.sh direct/indirect docker.io refs with imagestream image refs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2021-01-16T14:37:42Z

/cherrypick release-4.6

openshift-cherrypick-robot · 2021-01-16T14:40:17Z

@gabemontero: new pull request created: #25805

Details

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned bparees Jan 14, 2021

openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 14, 2021

openshift-ci-robot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jan 14, 2021

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 14, 2021

openshift-ci-robot requested review from ironcladlou and knobunc January 14, 2021 16:53

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 14, 2021

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021

gabemontero force-pushed the bld-cmd-docker-io branch 3 times, most recently from 75352b7 to 535c31f Compare January 15, 2021 02:36

xiuwang reviewed Jan 15, 2021

View reviewed changes

gabemontero force-pushed the bld-cmd-docker-io branch 2 times, most recently from 8ade3f6 to 7e03446 Compare January 15, 2021 15:47

gabemontero added 2 commits January 15, 2021 19:12

replace test/cmd/builds.sh direct/indirect docker.io refs with images…

087a846

…tream image refs

make update output

aad9d63

gabemontero force-pushed the bld-cmd-docker-io branch from 7e03446 to aad9d63 Compare January 16, 2021 00:13

gabemontero changed the title ~~Bug 1915907: remove more docker.io ref escapee from build e2e's~~ Bug 1915907: replace test/cmd/builds.sh direct/indirect docker.io refs with imagestream image refs Jan 16, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2021

openshift-merge-robot merged commit b2544d7 into openshift:master Jan 16, 2021

gabemontero deleted the bld-cmd-docker-io branch January 16, 2021 14:37

openshift-cherrypick-robot mentioned this pull request Jan 16, 2021

[release-4.6] Bug 1917014: replace test/cmd/builds.sh direct/indirect docker.io refs with imagestream image refs #25805

Merged

gabemontero mentioned this pull request Jan 26, 2021

Bug 1919453: Update to latest 4.7 state where possible #25821

Closed

Bug 1915907: replace test/cmd/builds.sh direct/indirect docker.io refs with imagestream image refs #25798

Bug 1915907: replace test/cmd/builds.sh direct/indirect docker.io refs with imagestream image refs #25798

Uh oh!

Conversation

gabemontero commented Jan 14, 2021

Uh oh!

openshift-ci-robot commented Jan 14, 2021

Uh oh!

gabemontero commented Jan 14, 2021

Uh oh!

openshift-ci-robot commented Jan 14, 2021

Uh oh!

bparees commented Jan 14, 2021

Uh oh!

gabemontero commented Jan 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabemontero commented Jan 14, 2021

Uh oh!

xiuwang Jan 15, 2021

Choose a reason for hiding this comment

Uh oh!

gabemontero commented Jan 15, 2021

Uh oh!

gabemontero commented Jan 15, 2021

Uh oh!

gabemontero commented Jan 16, 2021

Uh oh!

gabemontero commented Jan 16, 2021

Uh oh!

bparees commented Jan 16, 2021

Uh oh!

openshift-ci-robot commented Jan 16, 2021

Uh oh!

openshift-bot commented Jan 16, 2021

Uh oh!

openshift-ci-robot commented Jan 16, 2021

Uh oh!

gabemontero commented Jan 16, 2021

Uh oh!

openshift-cherrypick-robot commented Jan 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gabemontero commented Jan 14, 2021 •

edited

Loading