Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #25810

/assign gabemontero

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1916897 with correct target release. Retitling PR to link to clone:
/retitle [release-4.6] Bug 1920626: add test to verify build /run fs contents

Details

In response to this:

[release-4.6] Bug 1916897: add test to verify build /run fs contents

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1916897: add test to verify build /run fs contents [release-4.6] Bug 1920626: add test to verify build /run fs contents Jan 27, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 27, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1920626, which is invalid:

  • expected dependent Bugzilla bug 1916897 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.6] Bug 1920626: add test to verify build /run fs contents

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor

this needs openshift/builder#211 and openshift/builder#212 for all the new tests to pass

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign derekwaynecarr after the PR has been reviewed.
You can assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2021

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify 076c70d link /test verify
ci/prow/verify-deps 076c70d link /test verify-deps
ci/prow/images 076c70d link /test images
ci/prow/e2e-aws-csi 076c70d link /test e2e-aws-csi
ci/prow/e2e-gcp 076c70d link /test e2e-gcp
ci/prow/e2e-agnostic-cmd 076c70d link /test e2e-agnostic-cmd
ci/prow/e2e-gcp-builds 076c70d link /test e2e-gcp-builds
ci/prow/e2e-aws-fips 076c70d link /test e2e-aws-fips
ci/prow/e2e-aws-serial 076c70d link /test e2e-aws-serial
ci/prow/e2e-aws 076c70d link /test e2e-aws
ci/prow/e2e-gcp-upgrade 076c70d link /test e2e-gcp-upgrade
ci/prow/e2e-aws-upgrade 076c70d link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gabemontero
Copy link
Contributor

also, the images package used by the e2e is not in 4.6 yet:

test/extended/builds/run_fs_verification.go:11:2: cannot find package "." in:
	/go/src/github.com/openshift/origin/test/extended/util/image

but Clatyon is adding it with #25821

ideally we wait for that vs. closing this PR and doing a manual pick that replaces image.ShellImage()

@gabemontero
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 28, 2021
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1920626, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1916897 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1916897 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 28, 2021
@gabemontero
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link

@gabemontero: An error was encountered searching for bug 1920626 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 502 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. and removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Jan 28, 2021
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1920626, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1916897 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1916897 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor

also, the images package used by the e2e is not in 4.6 yet:

test/extended/builds/run_fs_verification.go:11:2: cannot find package "." in:
	/go/src/github.com/openshift/origin/test/extended/util/image

but Clatyon is adding it with #25821

ideally we wait for that vs. closing this PR and doing a manual pick that replaces image.ShellImage()

So given the new urgent level of this bug, there is a decision to be made on how long we wait for #25821 to merge so this PR's changes compile, or if I switch to doing a manual pick of the 4.7 change in my own PR and change image.ShellImage() to what it returns, image-registry.openshift-image-registry.svc:5000/openshift/tools:latest

I won't close this PR yet, but will start on that manual pick and report back after when we have a decision.

Note, the openshift/builder code change PRs have merged.

@gabemontero
Copy link
Contributor

/close

@gabemontero
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link

@gabemontero: Bugzilla bug 1920626 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@gabemontero: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants