Skip to content

Bug 1741679: Bump cadvisor [3.11.z] #23620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Sep 20, 2019
Merged

Bug 1741679: Bump cadvisor [3.11.z] #23620

openshift-merge-robot merged 3 commits into from
Sep 20, 2019

Conversation

@sjenning
Copy link
Contributor

@sjenning sjenning commented Aug 16, 2019

master PR #23585
4.1.z PR #23619

pull in openshift/google-cadvisor#7

The delta is larger because a make update-deps on a clean origin/master makes a lot of changes and the github.com/apcera/gssapi dep needed to be redirected to the openshift fork because that repo doesn't exist anymore. I've split up the bump(*) on the clean master into a separate commit.

Fixes #23492

@derekwaynecarr @deads2k @mfojtik

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 16, 2019

@sjenning: This pull request references an invalid Bugzilla bug:

  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1741679: Bump cadvisor [3.11.z]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 16, 2019
@sjenning sjenning force-pushed the bump-cadvisor-3.11 branch from e8cb5ad to fdbe14c Compare August 16, 2019 20:02
@enj enj mentioned this pull request Aug 22, 2019
Closed
@Reamer
Copy link

Reamer commented Sep 10, 2019

/test unit

@gnufied
Copy link
Member

gnufied commented Sep 10, 2019

Can someone lgtm this? I am waiting for this PR to merge so as I can update my PR - #23496 . We have provided a hotfix build to a customer based on #23496 PR and the PR fixes the issue but to ensure that the patch is incorpoprated in next version of 3.11.z, we will have to merge this PR and #23496

@rphillips
Copy link
Contributor

rphillips commented Sep 10, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gnufied
Copy link
Member

gnufied commented Sep 10, 2019

/retest

@gnufied
Copy link
Member

gnufied commented Sep 10, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 10, 2019

@gnufied: This pull request references Bugzilla bug 1741679, which is invalid:

  • expected dependent Bugzilla bug 1741681 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member

gnufied commented Sep 12, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 12, 2019

@gnufied: This pull request references Bugzilla bug 1741679, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 12, 2019
@gnufied gnufied mentioned this pull request Sep 12, 2019
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

20 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Sep 12, 2019

/hold

Until the jobs are fixed

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2019
@Reamer
Copy link

Reamer commented Sep 20, 2019

Would love to see this fix in release-3.11 branch.

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Sep 20, 2019

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2019
@openshift-merge-robot openshift-merge-robot merged commit 1f48d99 into openshift:release-3.11 Sep 20, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 20, 2019

@sjenning: All pull requests linked via external trackers have merged. Bugzilla bug 1741679 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1741679: Bump cadvisor [3.11.z]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Reamer Reamer mentioned this pull request Oct 2, 2019
Closed
@nalind nalind mentioned this pull request Dec 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sttts sttts Awaiting requested review from sttts

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@deads2k deads2k Awaiting requested review from deads2k

@bparees bparees Awaiting requested review from bparees

@timlnx timlnx Awaiting requested review from timlnx

Assignees

@rphillips rphillips

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sjenning @openshift-ci-robot @Reamer @gnufied @rphillips @openshift-bot @stevekuznetsov @openshift-merge-robot