Skip to content

[release-3.11] Bug 1730446: bump(github.com/openshift/imagebuilder) #23562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nalind wants to merge 1 commit into from
Closed

[release-3.11] Bug 1730446: bump(github.com/openshift/imagebuilder) #23562

nalind wants to merge 1 commit into from

Conversation

@nalind
Copy link
Member

@nalind nalind commented Aug 6, 2019

Revendor the openshift-3.11 branch of openshift/imagebuilder to pick up its fix for #1730446.
Move the version override for github.com/evanphx/json-patch in glide.yaml to its stanza to get update-deps to pass.
Mark bitbucket.org/ww/goautoneg as a mercurial repository, as my copy of glide had trouble automatically detecting that.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 6, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 6, 2019

@nalind: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

[release-3.11] Bug 1730446: bump(github.com/openshift/imagebuilder)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2019
@p0lyn0mial
Copy link
Contributor

p0lyn0mial commented Aug 7, 2019

@nalind I fixed github.com/evanphx/json-patch in #23565, could you just rebase?

@nalind nalind force-pushed the 3.11-revendor-imagebuilder branch from 860aa10 to ab25c31 Compare August 7, 2019 14:50
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 7, 2019
@nalind
Copy link
Member Author

nalind commented Aug 7, 2019

Okay, rebased.

@p0lyn0mial
Copy link
Contributor

p0lyn0mial commented Aug 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 7, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nalind, p0lyn0mial
To complete the pull request process, please assign mfojtik
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nalind
Copy link
Member Author

nalind commented Aug 7, 2019

/retest

@nalind
Copy link
Member Author

nalind commented Aug 7, 2019

/test cmd

@nalind
bump(github.com/openshift/imagebuilder)
a7dd446 
Revendor the openshift-3.11 branch of openshift/imagebuilder to pick up
its fix for #1730446.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@nalind
Copy link
Member Author

nalind commented Aug 8, 2019

Rebased to resolve conflicts.

@nalind nalind force-pushed the 3.11-revendor-imagebuilder branch from ab25c31 to a7dd446 Compare August 8, 2019 14:22
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 8, 2019

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2019
@bparees
Copy link
Contributor

bparees commented Sep 16, 2019

@nalind is this read to be merged?

@TomSweeneyRedHat
Copy link

TomSweeneyRedHat commented Dec 2, 2019

@nalind ping! Is this ready to go?

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2019

@nalind: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nalind
Copy link
Member Author

nalind commented Dec 3, 2019

Looks like the version bump I was attempting here was merged as part of #23620, so closing this.

@nalind nalind closed this Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@p0lyn0mial p0lyn0mial

Labels

bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nalind @openshift-ci-robot @p0lyn0mial @bparees @TomSweeneyRedHat