Bug 1741681: Bump cadvisor [4.1.z] #23619

sjenning · 2019-08-16T18:32:02Z

master PR #23585

The delta is larger because a make update-deps on a clean origin/master makes a lot of changes and the github.com/apcera/gssapi dep needed to be redirected to the openshift fork because that repo doesn't exist anymore. I've split up the bump(*) on the clean master into a separate commit.

Fixes #23492

@derekwaynecarr @deads2k @mfojtik

openshift-ci-robot · 2019-08-16T18:32:07Z

@sjenning: This pull request references an invalid Bugzilla bug:

expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1741681: Bump cadvisor [4.1.z]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sjenning · 2019-08-16T18:35:09Z

@deads2k note the removal of DefaultServingCertificate in the openshift/api bump. Want to make sure that is ok.

sjenning · 2019-08-16T18:54:53Z

well, I guess it isn't fine

 ++ Building go targets for linux/amd64: cmd/hypershift vendor/k8s.io/kubernetes/cmd/hyperkube
# github.com/openshift/origin/pkg/admission/customresourcevalidation/apiserver
pkg/admission/customresourcevalidation/apiserver/validate_apiserver.go:120:26: spec.ServingCerts.DefaultServingCertificate undefined (type "github.com/openshift/origin/vendor/github.com/openshift/api/config/v1".APIServerServingCerts has no field or method DefaultServingCertificate)
pkg/admission/customresourcevalidation/apiserver/validate_apiserver.go:131:29: newSpec.ServingCerts.DefaultServingCertificate undefined (type "github.com/openshift/origin/vendor/github.com/openshift/api/config/v1".APIServerServingCerts has no field or method DefaultServingCertificate)

need to adjust the pin for openshift/api for 4.1

sjenning · 2019-08-16T20:47:46Z

openshift/api#375 should not have been picked back to openshift/api release 4.1 branch...

eparis · 2019-08-20T17:05:00Z

/bugzilla refresh

openshift-ci-robot · 2019-08-20T17:05:08Z

@eparis: This pull request references Bugzilla bug 1741681, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eparis · 2019-08-24T18:58:41Z

This need engineering review/lgtm/approval
/retest

sjenning · 2019-08-29T03:19:09Z

/retest

…3e8a9

sjenning · 2019-08-29T12:41:53Z

/retest

rphillips · 2019-08-29T17:14:42Z

/lgtm

openshift-ci-robot · 2019-08-29T17:14:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mfojtik · 2019-09-02T09:02:23Z

pkg/admission/customresourcevalidation/apiserver/validate_apiserver.go

 	}

 	errs = append(errs, validation.ValidateObjectMeta(&obj.ObjectMeta, false, customresourcevalidation.RequireNameCluster, field.NewPath("metadata"))...)
-	errs = append(errs, validateAPIServerSpecCreate(obj.Spec)...)


@sjenning how is this related to the cadvisor bump?

@mfojtik it isn't, but openshift/api#375 went into openshift/api branch release-4.1 and after the bump, the build failed without this change

mfojtik · 2019-09-02T09:02:56Z

glide.lock

  - config/v1beta1
 - name: k8s.io/kubernetes
-  version: cc2afe3181bd5593ad5c03e9a768e3ff270ec343
+  version: fd7008ebbbb179b36367d02fc929ca7eb514d0b0


hmm why this moved and what is this level?

/cc @deads2k @sttts

Is the bot broken?

$ git log cc2afe3181bd5593ad5c03e9a768e3ff270ec343..fd7008ebbbb179b36367d02fc929ca7eb514d0b0 --oneline fd7008ebbbb Merge pull request #23517 from sttts/sttts-procmount-4.1 cf981128196 Merge pull request #23524 from rphillips/backport_4.1/80657 dbd6628aba9 UPSTREAM: 80657: add UID to kubelet_container_log_filesystem_used_bytes metric d78ddd3c037 UPSTREAM: 78882: Fix incorrect procMount defaulting f27555ff6d6 Merge pull request #23367 from RobertKrawitz/upstream-79391-4.1 4597d2ea87f bump 32ecfe871e5 UPSTREAM: 79391: Don't use strategic merge patch on Node.Status.Addresses

openshift-ci-robot · 2019-09-06T20:54:25Z

@sjenning: All pull requests linked via external trackers have merged. Bugzilla bug 1741681 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1741681: Bump cadvisor [4.1.z]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

glide: point github.com/apcera/gssapi dep to openshift fork

796d1aa

sjenning requested review from deads2k, derekwaynecarr, mfojtik and soltysh August 16, 2019 18:32

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2019

openshift-ci-robot requested a review from smarterclayton August 16, 2019 18:35

sjenning mentioned this pull request Aug 16, 2019

Bug 1741679: Bump cadvisor [3.11.z] #23620

Merged

sjenning added 2 commits August 16, 2019 15:56

remove DefaultServingCertificate validation

a194947

bump(*)

a29f95f

sjenning force-pushed the bump-cadvisor-4.1 branch from 308b60d to 1ae5654 Compare August 16, 2019 21:00

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 20, 2019

regen openapi

95930b6

sjenning force-pushed the bump-cadvisor-4.1 branch from 1ae5654 to 4a1c61e Compare August 28, 2019 20:50

bump(github.com/google/cadvisor): 5fa6b13d2628c5c85c8508082cc1bdfa337…

ea5682a

…3e8a9

sjenning force-pushed the bump-cadvisor-4.1 branch from 4a1c61e to ea5682a Compare August 29, 2019 03:42

sjenning assigned derekwaynecarr Aug 29, 2019

openshift-ci-robot assigned rphillips Aug 29, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2019

mfojtik reviewed Sep 2, 2019

View reviewed changes

openshift-ci-robot requested a review from sttts September 2, 2019 09:04

mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 6, 2019

openshift-merge-robot merged commit da040ab into openshift:release-4.1 Sep 6, 2019

Bug 1741681: Bump cadvisor [4.1.z] #23619

Bug 1741681: Bump cadvisor [4.1.z] #23619

Uh oh!

Conversation

sjenning commented Aug 16, 2019

Uh oh!

openshift-ci-robot commented Aug 16, 2019

Uh oh!

sjenning commented Aug 16, 2019

Uh oh!

sjenning commented Aug 16, 2019

Uh oh!

sjenning commented Aug 16, 2019

Uh oh!

eparis commented Aug 20, 2019

Uh oh!

openshift-ci-robot commented Aug 20, 2019

Uh oh!

eparis commented Aug 24, 2019

Uh oh!

sjenning commented Aug 29, 2019

Uh oh!

sjenning commented Aug 29, 2019

Uh oh!

rphillips commented Aug 29, 2019

Uh oh!

openshift-ci-robot commented Aug 29, 2019

Uh oh!

mfojtik Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

sjenning Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mfojtik Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

mfojtik Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

sttts Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Sep 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

sjenning Sep 5, 2019 •

edited

Loading