stop serving oauth config #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
Contributor
Author
|
required PRs have now merged /test all |
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
Well, this pull broken somehow. I'll need to try it again locally since everything is now. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
deads2k
removed
the
do-not-merge/hold
Contributor
Author
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
etcd dying |
deads2k
force-pushed
the
disable-oauth
branch
from
ff62bea to
22d6fa6
Compare
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
this works locally for me |
Contributor
Author
|
/retest |
1 similar comment
Contributor
|
/retest |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
deads2k
force-pushed
the
disable-oauth
branch
from
22d6fa6 to
66b5434
Compare
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
I think I found it. the files merged on top had partial stanzas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires openshift/origin#22054
This removes the oauthConfig and makes it impossible to specify one via our operator.
@openshift/sig-master