Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase to Kube 0.14 #1659

Merged
merged 26 commits into from
Apr 10, 2015
Merged

Conversation

smarterclayton
Copy link
Contributor

@pweil- please see the commit on how ports have changed.

@smarterclayton
Copy link
Contributor Author

So much rebase...

@smarterclayton
Copy link
Contributor Author

[test]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1774/)

@smarterclayton smarterclayton changed the title WIP - Rebase to Kube 0.14 Rebase to Kube 0.14 Apr 9, 2015
@smarterclayton
Copy link
Contributor Author

Squash incoming

smarterclayton and others added 21 commits April 9, 2015 23:16
Need to work with go-systemd to see if we can abstract the syscall.CloseOnExec
which is not supported on windows.
* kubectl/cmd/Factory moved
* Labels/FieldsSelectorParams args changed
* Pod.Status.Host -> Pod.Spec.Host
* Add ListKeys() to EventQueue
In most cases, assume the first port and handle as gracefully as
possible. Will need follow up work.
@smarterclayton
Copy link
Contributor Author

[merge]

@smarterclayton
Copy link
Contributor Author

@mfojtik / @bparees after this change lands someone needs to investigate osc build-logs (it's failing in the end-to-end tests). It might be @derekwaynecarr's changes to require namespace to be specified interacting with the test, but I wasn't able to run it down in a short period of time.

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1774/) (Image: devenv-fedora_1252)

@smarterclayton
Copy link
Contributor Author

[merge]

@smarterclayton
Copy link
Contributor Author

@pweil- if this doesn't merge tonight I'll need your help looking at TestRouter. I'm seeing:

$ docker logs e0156da40fb3
I0410 05:35:04.312742       1 router.go:64] Commiting router changes
E0410 05:35:04.334364       1 router.go:131] Error reloading router: exit status 127
 Reload output: + config_file=/var/lib/haproxy/conf/haproxy.config
+ pid_file=/var/lib/haproxy/run/haproxy.pid
+ old_pid=
+ path_map_file=/var/lib/haproxy/conf/os_http_be.map
+ sort -r /var/lib/haproxy/conf/os_http_be.map -o /var/lib/haproxy/conf/os_http_be.map
+ '[' -f /var/lib/haproxy/run/haproxy.pid ']'
+ '[' -n '' ']'
+ /usr/sbin/haproxy -f /var/lib/haproxy/conf/haproxy.config -p /var/lib/haproxy/run/haproxy.pid
/var/lib/haproxy/reload-haproxy: line 18: /usr/sbin/haproxy: No such file or directory
F0410 05:35:04.334429       1 router.go:45] exit status 127

in the docker logs when it tries to start haproxy, but don't know why.

@pweil-
Copy link

pweil- commented Apr 10, 2015

that is strange. I pulled this PR locally, built the images, and ran the container.

[vagrant@openshiftdev origin]$ docker ps
CONTAINER ID        IMAGE                                     COMMAND                CREATED             STATUS              PORTS               NAMES
023ee241b46b        openshift/origin-haproxy-router:ee831e7   "/usr/bin/openshift-   13 seconds ago      Up 12 seconds       80/tcp              sharp_lumiere       
[vagrant@openshiftdev origin]$ docker inspect 023ee | grep Pid
        "PidMode": "",
        "Pid": 7004,
[vagrant@openshiftdev origin]$ sudo nsenter -m -u -n -i -p -t 7004
[root@023ee241b46b /]# ll /usr/sbin/haproxy
-rwxr-xr-x. 1 root root 800656 Mar  6 00:30 /usr/sbin/haproxy
[root@023ee241b46b /]# 

@pweil-
Copy link

pweil- commented Apr 10, 2015

running hack/test-integration-docker.sh locally did show one issue for me. The v1beta3 ns is not supported by the http master simulator correctly, it was only registering v1beta1 urls. This fixes it for me.

func (s *TestHttpService) startMaster() error {
    masterServer := http.NewServeMux()
    apis := []string{"v1beta1", "v1beta2", "v1beta3"}

    for _, version := range apis {
        masterServer.HandleFunc(fmt.Sprintf("/api/%s/endpoints", version), s.handleEndpointList)
        masterServer.HandleFunc(fmt.Sprintf("/api/%s/watch/endpoints", version), s.handleEndpointWatch)
        masterServer.HandleFunc(fmt.Sprintf("/osapi/%s/routes", version), s.handleRouteList)
        masterServer.HandleFunc(fmt.Sprintf("/osapi/%s/watch/routes", version), s.handleRouteWatch)
    }

    masterServer.HandleFunc("/", s.handleHelloMaster)

    if err := s.startServing(s.MasterHttpAddr, masterServer); err != nil {
        return err
    }

    return nil
}
ok      TestRouter
ok      TestRouterPathSpecificity

@pweil-
Copy link

pweil- commented Apr 10, 2015

Travis flaked on one run with a bind address already in use but the other two runs passed and jenkins passed as well in my test PR: #1690

@smarterclayton
Copy link
Contributor Author

Open a pull to my branch

On Apr 10, 2015, at 9:30 AM, Paul [email protected] wrote:

Travis flaked on one run with a bind address already in use but the other two runs passed and jenkins passed as well in my test PR: #1690


Reply to this email directly or view it on GitHub.

@pweil-
Copy link

pweil- commented Apr 10, 2015

submitted

@bparees
Copy link
Contributor

bparees commented Apr 10, 2015

@smarterclayton what's the failure mode/error message for build-logs?

@smarterclayton
Copy link
Contributor Author

It says build not found (even though it does). It might be a namespace bug, or it could be a redirect bug.

On Apr 10, 2015, at 10:54 AM, Ben Parees [email protected] wrote:

@smarterclayton what's the failure mode/error message for build-logs?


Reply to this email directly or view it on GitHub.

@smarterclayton
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 726d211

openshift-bot pushed a commit that referenced this pull request Apr 10, 2015
@openshift-bot openshift-bot merged commit 6fc4a2e into openshift:master Apr 10, 2015
@smarterclayton smarterclayton modified the milestone: 0.5.0 (beta3) Apr 23, 2015
jboyd01 pushed a commit to jboyd01/origin that referenced this pull request Feb 6, 2018
…service-catalog/' changes from d969acde90..b69b4a6c80

b69b4a6c80 origin build: modify hard coded path
527fac4d02 origin build: add origin tooling
545ffdb chart changes for v0.1.5 release (openshift#1709)
4d9be8f Use userInfo for Originating-Identity so extras is correct. (openshift#1702)
f358b99 Call destroy function on each storage interface (openshift#1705)
36b5de9 refactor binding reconciliation functions (openshift#1687)
5699360 Change binding_retrievable to bindingRetrievable
0d8bcfe thread through stopCh to DestroyFunc (openshift#1671)
1c45aef Migrate from glide to dep for dependency management (openshift#1670)
1cf0dd9 Add svcat to Makefile (openshift#1683)
45b1013 make verify validates that versioned APIs contain json tags for fields, addresses openshift#1303 (openshift#1480)
0ee8398 Build the integration test binary before running any tests (openshift#1666)
0fe0aa7 Update design.md (openshift#1674)
1280d24 controller requires permission to update secrets (openshift#1663)
129d98e Contribute svcat (openshift#1664)
ff9739b Update dependencies to kubernetes-1.9.1 (openshift#1633)
9c36019 chart changes for v0.1.4 release (openshift#1669)
93319f6 move apiserver generation to script and verify (openshift#1662)
385f0da refactor service instance provision/update/poll reconciliation (openshift#1648)
e015212 run each integration test individually (openshift#1661)
412e242 Tell people whether we're checking external hrefs (openshift#1659)
ae05361 retry failed unbind requests (openshift#1653)
7eae845 doc for setting up Service Catalog with Prometheus metrics (openshift#1654)
0720cf9 minor README copy edit (openshift#1656)
8bd347d run some integration subtests in parallel (openshift#1637)
b83800c Use $ and console to indicate multi-command blocks
789c4b2 Use dynamic reaction to fix data race (openshift#1650)
f1be763 only check external hrefs on master (openshift#1652)
65c6d20 Controller-manager crash loops if API server is not available on startup (openshift#1376) (openshift#1591)
9225c92 embedded etcd is the way of the future for our tests (openshift#1651)
605c952 Fix required fields in OpenAPI schema (openshift#1602)
899ca21 Revert "Switch to wget for integration apiserver checks (openshift#1384)" (openshift#1585)
2f496ee Update code-of-conduct.md (openshift#1635)
c1c69cf Build the e2e binary in CI (openshift#1647)
4e2dcef Wait for successful API discovery (openshift#1646)
5ae6d99 Bump copyright date in generated code (openshift#1645)
8be5b05 Serve OpenAPI spec only when --serve-openapi-spec switch is enabled (openshift#1612)
19fb30e silence go-restful logging output (openshift#1622)
fdbabf0 Add walkthrough link back (openshift#1620)
7c73e9a Add link to main k8s docs on service-catalog (openshift#1627)
f59adc9 Overhauling the design document (openshift#1619)
cd7b633 Updating the install documentation (openshift#1616)
f6e5441 fix compilation error from updated util.WaitForBindingCondition() (openshift#1629) (openshift#1631)
54e57af Provide OSB Client proxy to instrument with metrics (openshift#1615)
026b86f Disable test added in 1611 that contains data race (openshift#1626)
cb735a6 Add integration tests for ServiceInstances (openshift#1611)
67dbabb Cleaning up the docs README (openshift#1618)
6bddc07 remove email from docker login during Travis deploy (openshift#1614)
a604bc3 Use ConfigMaps for leader election (openshift#1599)
c6f193a Add controller integration tests for ServiceInstance create and update (openshift#1578)
26cf23b Rename OWNERS assignees: to approvers: (openshift#1508)
1163edc expose Prometheus metrics from Controller (openshift#677) (openshift#1608)
2cd6554 Clean up docs/ folder (openshift#1609)
1d7e96d Adding Service Binding Create Integration Tests (openshift#1580)
6a4c469 Make the maximum polling backoff configurable (openshift#1607)
31bbf55 Rename the imported package to avoid name conflict (openshift#1603)
3cdd556 Add validation for broker spec to SAR admission controller (openshift#1605)
a3408ce fix docker volume mount when building with docker under SELinux (openshift#1500) (openshift#1534)
307e747 Remove unneeded vendors of vendors (openshift#1596)
770fc74 Make ups-instance.yaml in walkthrough to demonstrate good practices (openshift#1592)
9112ba1 Add links to docs/README (openshift#1589)
8902648 Add additional service to ups-broker to fix e2e (openshift#1583)
0bcbc7d move instance update logic out of reconcileServiceInstanceDelete (openshift#1584)
7ef5a3e Do not send Parameters field when there are no parameters from sourced secret (openshift#1559)
4c51b25 Remove unneeded code that sets reason for provision/update call failure (openshift#1561)
b122cb9 fix bind injection failure not being persisted in API server (openshift#1546)
66421d5 Clear out current operation when starting reconciliation of a delete (openshift#1564)
8cca70a Send an empty object for Parameters when deleting all parameters of a ServiceInstance (openshift#1555)
270426c Add controllerTest type as a helper for running controller integration tests. (openshift#1577)
e26c2d7 Ignore .vscode folder in project root (openshift#1579)
REVERT: d969acde90 Add additional service to ups-broker to fix e2e (openshift#1583)
REVERT: 1bcd53b684 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: b69b4a6c8003f25d040e3087c7b1b16d1854a9e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants