Skip to content

Commit f1be763

Browse files
Doug Davisarschles
Doug Davis
authored andcommitted
only check external hrefs on master (openshift#1652)
Signed-off-by: Doug Davis <[email protected]>
1 parent 65c6d20 commit f1be763

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

Diff for: Makefile

+8-1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,13 @@ TEST_DIRS ?= $(shell sh -c "find $(TOP_SRC_DIRS) -name \\*_test.go \
3434
-exec dirname {} \\; | sort | uniq")
3535
VERSION ?= $(shell git describe --always --abbrev=7 --dirty)
3636
BUILD_LDFLAGS = $(shell build/version.sh $(ROOT) $(SC_PKG))
37+
GIT_BRANCH ?= $(shell git rev-parse --abbrev-ref HEAD)
38+
39+
# Only skip the verification of external href's if we're not on 'master'
40+
SKIP_HTTP=-x
41+
ifeq ($(GIT_BRANCH),master)
42+
SKIP_HTTP=
43+
endif
3744

3845
# Run stat against /dev/null and check if it has any stdout output.
3946
# If stdout is blank, we are detecting bsd-stat because stat it has
@@ -237,7 +244,7 @@ verify: .init .generate_files verify-client-gen
237244
@rm .out
238245
@#
239246
@echo Running href checker:
240-
@$(DOCKER_CMD) verify-links.sh -t .
247+
@$(DOCKER_CMD) verify-links.sh -t $(SKIP_HTTP) .
241248
@echo Running errexit checker:
242249
@$(DOCKER_CMD) build/verify-errexit.sh
243250

0 commit comments

Comments
 (0)