Skip to content

Commit 5699360

Browse files
author
Jeff Peeler
committed
Change binding_retrievable to bindingRetrievable
This is to make the serialized name conform to API conventions. Also, changes example json files to match.
1 parent 0d8bcfe commit 5699360

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

Diff for: cmd/svcat/testdata/responses/clusterserviceclasses.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"externalID": "4f6e6cf6-ffdd-425f-a2c7-3c9258ad2468",
2121
"description": "A user provided service",
2222
"bindable": true,
23-
"binding_retrievable": false,
23+
"bindingRetrievable": false,
2424
"planUpdatable": true
2525
},
2626
"status": {

Diff for: cmd/svcat/testdata/responses/clusterserviceclasses/4f6e6cf6-ffdd-425f-a2c7-3c9258ad2468.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"externalID": "4f6e6cf6-ffdd-425f-a2c7-3c9258ad2468",
1515
"description": "A user provided service",
1616
"bindable": true,
17-
"binding_retrievable": false,
17+
"bindingRetrievable": false,
1818
"planUpdatable": true
1919
},
2020
"status": {

Diff for: cmd/svcat/testdata/responses/clusterserviceclasses?fieldSelector=spec.externalName=user-provided-service.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"externalID": "4f6e6cf6-ffdd-425f-a2c7-3c9258ad2468",
2121
"description": "A user provided service",
2222
"bindable": true,
23-
"binding_retrievable": false,
23+
"bindingRetrievable": false,
2424
"planUpdatable": true
2525
},
2626
"status": {

Diff for: pkg/apis/servicecatalog/v1beta1/types.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ type ClusterServiceClassSpec struct {
282282
//
283283
// BindingRetrievable indicates whether fetching a binding via a GET on
284284
// its endpoint is supported for all plans.
285-
BindingRetrievable bool `json:"binding_retrievable"`
285+
BindingRetrievable bool `json:"bindingRetrievable"`
286286

287287
// PlanUpdatable indicates whether instances provisioned from this
288288
// ClusterServiceClass may change ClusterServicePlans after being

Diff for: pkg/openapi/openapi_generated.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ func GetOpenAPIDefinitions(ref common.ReferenceCallback) map[string]common.OpenA
393393
Format: "",
394394
},
395395
},
396-
"binding_retrievable": {
396+
"bindingRetrievable": {
397397
SchemaProps: spec.SchemaProps{
398398
Description: "Currently, this field is ALPHA: it may change or disappear at any time and its data will not be migrated.\n\nBindingRetrievable indicates whether fetching a binding via a GET on its endpoint is supported for all plans.",
399399
Type: []string{"boolean"},
@@ -442,7 +442,7 @@ func GetOpenAPIDefinitions(ref common.ReferenceCallback) map[string]common.OpenA
442442
},
443443
},
444444
},
445-
Required: []string{"clusterServiceBrokerName", "externalName", "externalID", "description", "bindable", "binding_retrievable", "planUpdatable"},
445+
Required: []string{"clusterServiceBrokerName", "externalName", "externalID", "description", "bindable", "bindingRetrievable", "planUpdatable"},
446446
},
447447
},
448448
Dependencies: []string{

0 commit comments

Comments
 (0)