delete non-junit file before junit merge#16083
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test extended_image_ecosystem |
|
@stevekuznetsov fyi |
|
(the right fix for this is #16068 but that is on hold pending @smarterclayton's confirmation that we don't need junit merge for anything else) |
|
@bparees the 10x simpler solutions is to pass in TEST_REPORT_DIR that is not OUTPUT_DIR or ARTIFACT_DIR but some subdir. Why not do that? |
because i don't know what the subdir is supposed to be. and i'd have to change everywhere it's being set. and this function is going away. |
|
TEST_REPORT_DIR is declarative -- you pass it in to set it. But yes, let's just delete the /close |
|
@stevekuznetsov i need a solution to junit merge today. since @smarterclayton is blocking the other PR, this is the expedient solution in the meantime. |
His worry about Gubernator is unfounded. That PR should be unblocked. |
|
Please set |
|
@stevekuznetsov has convinced me this probably won't work. |
|
@bparees: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@openshift-ci-robot stop, it's already dead |
No description provided.