Skip to content

delete non-junit file before junit merge#16083

Closed
bparees wants to merge 1 commit into
openshift:masterfrom
bparees:junit_patch
Closed

delete non-junit file before junit merge#16083
bparees wants to merge 1 commit into
openshift:masterfrom
bparees:junit_patch

Conversation

@bparees
Copy link
Copy Markdown
Contributor

@bparees bparees commented Aug 31, 2017

No description provided.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2017
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 31, 2017
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Aug 31, 2017

/test extended_image_ecosystem
/test_extended_builds

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Aug 31, 2017

@stevekuznetsov fyi

@bparees bparees added retest-not-required lgtm Indicates that a PR is ready to be merged. labels Aug 31, 2017
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Aug 31, 2017

(the right fix for this is #16068 but that is on hold pending @smarterclayton's confirmation that we don't need junit merge for anything else)

@stevekuznetsov
Copy link
Copy Markdown
Contributor

@bparees the 10x simpler solutions is to pass in TEST_REPORT_DIR that is not OUTPUT_DIR or ARTIFACT_DIR but some subdir. Why not do that?

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Aug 31, 2017

@bparees the 10x simpler solutions is to pass in TEST_REPORT_DIR that is not OUTPUT_DIR or ARTIFACT_DIR but some subdir. Why not do that?

because i don't know what the subdir is supposed to be. and i'd have to change everywhere it's being set. and this function is going away.

@stevekuznetsov
Copy link
Copy Markdown
Contributor

TEST_REPORT_DIR is declarative -- you pass it in to set it. But yes, let's just delete the junitmerge functionality instead.

/close

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Aug 31, 2017

@stevekuznetsov i need a solution to junit merge today. since @smarterclayton is blocking the other PR, this is the expedient solution in the meantime.

@stevekuznetsov
Copy link
Copy Markdown
Contributor

since @smarterclayton is blocking the other PR

His worry about Gubernator is unfounded. That PR should be unblocked.

@stevekuznetsov stevekuznetsov removed the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2017
@stevekuznetsov
Copy link
Copy Markdown
Contributor

Please set $TEST_REPORT_DIR to some subdir of artifacts and mkdir it:

test/extended/networking.sh:373:    export TEST_REPORT_DIR="${ARTIFACT_DIR}"
test/extended/setup.sh:53:              export TEST_REPORT_DIR="${ARTIFACT_DIR}"

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Aug 31, 2017

@stevekuznetsov has convinced me this probably won't work.

@bparees bparees closed this Aug 31, 2017
@bparees bparees deleted the junit_patch branch August 31, 2017 16:51
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 31, 2017

@bparees: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_image_ecosystem 0f24396 link /test extended_image_ecosystem
ci/openshift-jenkins/extended_conformance_gce 0f24396 link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevekuznetsov
Copy link
Copy Markdown
Contributor

@openshift-ci-robot stop, it's already dead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. retest-not-required size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants