Skip to content

stop calling junit merge.#16068

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
bparees:junit
Oct 23, 2017
Merged

stop calling junit merge.#16068
openshift-merge-robot merged 1 commit into
openshift:masterfrom
bparees:junit

Conversation

@bparees
Copy link
Copy Markdown
Contributor

@bparees bparees commented Aug 30, 2017

since jenkinsci/junit-plugin#54 was merged,
it should not be needed anymore.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 30, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2017
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Aug 30, 2017

@stevekuznetsov ptal

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Aug 30, 2017

/test extended_builds

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 30, 2017
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Aug 30, 2017

/test extended_builds

@jim-minter
Copy link
Copy Markdown
Contributor

lgtm but leaving it to @stevekuznetsov

@stevekuznetsov
Copy link
Copy Markdown
Contributor

/unassign @Kargakis
/assign @smarterclayton
/assign

since jenkinsci/junit-plugin#54 was merged,
it should not be needed anymore.
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Aug 31, 2017

/test extended_builds

@smarterclayton
Copy link
Copy Markdown
Contributor

It's required for other tools.

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Aug 31, 2017

It's required for other tools.

are you saying we need to leave the junitmerge tool here, or are you saying we can't stop calling junit merge at all?

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Aug 31, 2017

/retest

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Aug 31, 2017 via email

@stevekuznetsov
Copy link
Copy Markdown
Contributor

I confirmed we're fine for Gubernator -- it expects many jUnit files

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Aug 31, 2017

/retest

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Aug 31, 2017

I need a decision on whether this PR can move forward, it's screwing up our extended test runs.

@stevekuznetsov
Copy link
Copy Markdown
Contributor

In my opinion it should be good

@stevekuznetsov
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2017
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, stevekuznetsov

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@0xmichalis
Copy link
Copy Markdown
Contributor

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2017
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Sep 21, 2017

@stevekuznetsov @smarterclayton bump.

@stevekuznetsov
Copy link
Copy Markdown
Contributor

So we do NOT need this for Gubernator ... @smarterclayton any objections?

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 23, 2017

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2017
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 23, 2017

(i heard no objections).

@bparees bparees added the kind/bug Categorizes issue or PR as related to a bug. label Oct 23, 2017
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 70b04f0 into openshift:master Oct 23, 2017
@bparees bparees deleted the junit branch October 25, 2017 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants