fix sorting based on build id; incorporate start time wrt finding lat…

[gabemontero]

…est build

fixes #153

@openshift/devex fyi

[bparees]

lgtm

[gabemontero]

jenkins recycled during the tests ... broke a couple of in-flight activities

running tests locally now ... if pass, merging manually

[gabemontero]

jenkins recycle <== recent ci.openshift env pain

[bparees]

running tests locally now ... if pass, merging manually

why does it need to be merged manually?

[bparees]

this doesn't seem urgent enough to justify bypassing our test/merge process.

[gabemontero]

rosie is going to complain if I don't cite a flake ... and it has to be a flake from this repo

[bparees]

just delete the rosie comments.

[gabemontero]

ok (delete comment)

[gabemontero]

fyi ... tests did pass locally for me

[bparees]

Using project "default".
unexpected top level element in /data/src/github.com/openshift/origin/_output/scripts/core/artifacts/build-job-clone.xml: flow-definition
[ERROR] PID 41423: test/extended/setup.sh:251: `"$( os::util::find::built_binary junitmerge )" "${TEST_REPORT_DIR}"/*.xml > "${output}"` exited with status 1.
[INFO] 		Stack Trace: 
[INFO] 		  1: test/extended/setup.sh:251: `"$( os::util::find::built_binary junitmerge )" "${TEST_REPORT_DIR}"/*.xml > "${output}"`
[INFO] 		  2: test/extended/setup.sh:26: os::test::extended::merge_junit
[INFO] 		  3: test/extended/core.sh:9: os::test::extended::focus

we need to get to the bottom of that. according to @stevekuznetsov we're including files that are not junit output and should not be merged, in the junit merge operation.

[bparees]

removing junitmerge here:
openshift/origin#16068

[gabemontero]

Thanks for the investigation/insight @bparees

Given this fix is still low priority (though I ultimately want to get it in 3.7), I'll defer on hitting the merge button, and try the tag again when appropriate.

[bparees]

may fix is this way instead: openshift/origin#16083 for now.

[gabemontero]

deleting / updating comments in prep to avoid "flake req" on next attempt

[bparees]

ok, this will be the PR that should fix it: openshift/origin#16085

[bparees]

[merge]

[gabemontero]

16085 has merged

trying [merge]

[openshift-bot]

Evaluated for jenkins plugin merge up to c22198d

[stevekuznetsov]

Since you're running off of the build stage you need to wait for a new one to have been built

[stevekuznetsov]

[merge]

[openshift-bot]

continuous-integration/openshift-jenkins-plugin/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_jenkins_plugin/4/) (Base Commit: 045549b) (PR Branch Commit: c22198d) (Image: devenv-rhel7_5)

[bparees]

hooray. Thanks @stevekuznetsov

[stevekuznetsov]

🔥

[gabemontero]

yes thanks @stevekuznetsov !!