Implement `osc status` #1314

smarterclayton · 2015-03-16T03:49:15Z

Displays a simple grouping of resources active in the current project. More changes will come later.

smarterclayton · 2015-03-30T18:31:13Z

@jwforres review please

smarterclayton · 2015-03-30T18:31:22Z

Needs tests, will add those.

jwforres · 2015-03-30T20:59:28Z

pkg/api/graph/deployment.go

we've talked about calling these pipelines in the UI, easier to find the code in the API if the terminology is consistent :)

jwforres · 2015-03-30T21:06:32Z

pkg/api/graph/deployment.go

rename to match whatever you call ImageDeploymentFlow

jwforres · 2015-03-30T21:15:38Z

pkg/api/graph/deployment.go

so the same ImageDeploymentFlows referenced by Builds might also be referenced by ImageDeploymentFlows within the DeploymentFlows under Deployments? Or are the ImageDeploymentFlows referenced by Builds only ones that are not already part of a DeploymentFlow?

jwforres · 2015-03-30T21:39:06Z

pkg/api/graph/graph.go

So it doesn't overlap with "Kind()" the method. Consistent with underlying gonum/graph

----- Original Message -----

return node
+}

+type MutableDirectedEdge interface {

AddEdge(head, tail graph.Node, edgeKind int)
+}

+type MutableUniqueGraph interface {

graph.Mutable

MutableDirectedEdge

UniqueNodeInitializer
+}

+type Edge struct {

concrete.Edge

K int

K?

Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1314/files#r27434692

fabianofranz · 2015-03-31T17:37:13Z

pkg/cmd/cli/cmd/status.go

Should we also support project as an argument, and use the default if not provided (same approach as osc project)?

I don't think so - this is like Git status.

----- Original Message -----

+const statusLongDesc = +Show a high level overview of the current project. + +
+
+func NewCmdStatus(fullName string, f *clientcmd.Factory, out io.Writer)
*cobra.Command {

cmd := &cobra.Command{

Use: "status",

Short: "Give an overview of the current project",

Long: fmt.Sprintf(statusLongDesc, fullName),

Run: func(cmd *cobra.Command, args []string) {

client, kclient, err := f.Clients()

checkErr(err)

namespace, err := f.DefaultNamespace()

Should we also support project as an argument, and use the default if not
provided (same approach as osc project)?

Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1314/files#r27502757

fabianofranz · 2015-03-31T17:50:12Z

pkg/cmd/cli/describe/describer.go

BTW the other day I found these, worth a look:

https://github.com/bndr/gotabulate
https://github.com/olekukonko/tablewriter

After 3.0 :)

----- Original Message -----

return "", err

}

g := graph.New()

for i := range ) {

graph.BuildConfig(g, &bcs.Items[i])

}

for i := range dcs.Items {

graph.DeploymentConfig(g, &dcs.Items[i])

}

for i := range svcs.Items {

graph.Service(g, &svcs.Items[i])

}

groups := graph.ServiceAndDeploymentGroups(graph.CoverServices(g))

return tabbedString(func(out *tabwriter.Writer) error {

BTW the other day I found these, worth a look:

https://github.com/bndr/gotabulate
https://github.com/olekukonko/tablewriter

Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1314/files#r27504066

There's a story: https://trello.com/c/04lpfTQR/586-3-uicomp-future-improved-help-and-ux-in-the-cli

fabianofranz · 2015-03-31T18:00:17Z

pkg/cmd/cli/cmd/status.go

Add a TODO to support --watch (may be hard).

Naw, I don't think we'd do that either. Let's just say that we will evolve status in the future. I don't think watch will work from a CLI experience really.

----- Original Message -----

Long: fmt.Sprintf(statusLongDesc, fullName),

Run: func(cmd *cobra.Command, args []string) {

client, kclient, err := f.Clients()

checkErr(err)

namespace, err := f.DefaultNamespace()

checkErr(err)

describer := &describe.ProjectStatusDescriber{kclient, client}

s, err := describer.Describe(namespace, "")

checkErr(err)

fmt.Fprintf(out, s)

},

}

return cmd

Add a TODO to support --watch (may be hard).

Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1314/files#r27505138

jwforres · 2015-04-01T17:57:05Z

osc status for an empty project should probably suggest they create things? new-app?

right now all it outputs is:

In project OpenShift 3 Sample (test)

jwforres · 2015-04-01T17:59:19Z

Might want to add some space around the -> so its easier to read, so instead of:

service database (172.30.17.115:5434->3306)

do this

service database (172.30.17.115:5434 -> 3306)

jwforres · 2015-04-01T18:01:17Z

its not clear what the last part of this line means

frontend deploys origin-ruby-sample:latest <- git://github.com/openshift/ruby-hello-world.git on test/ruby-20-centos7:latest

maybe say "built on" instead of just "on"

jwforres · 2015-04-01T18:12:38Z

when my first build failed, nothing in osc status told me the build related to my service had failed, we show it in the console

service frontend (172.30.17.34:5432->8080)
  frontend deploys origin-ruby-sample:latest <- git://github.com/openshift/ruby-hello-world.git on test/ruby-20-centos7:latest

smarterclayton · 2015-04-01T20:19:51Z

Not implemented yet.

----- Original Message -----

when my first build failed, nothing in osc status told me the build related
to my service had failed, we show it in the console
service frontend (172.30.17.34:5432->8080)
  frontend deploys origin-ruby-sample:latest <-
  git://github.com/openshift/ruby-hello-world.git on
  test/ruby-20-centos7:latest
Reply to this email directly or view it on GitHub:
#1314 (comment)

smarterclayton · 2015-04-01T21:27:54Z

All comments addressed as per verbal LGTM from jessica [merge]

openshift-bot · 2015-04-01T21:30:48Z

[Test]ing while waiting on the merge queue

smarterclayton · 2015-04-02T20:11:06Z

[merge]

openshift-bot · 2015-04-02T22:10:43Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1703/)

openshift-bot · 2015-04-02T22:10:52Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1464/) (Image: devenv-fedora_1204)

…tionships

openshift-bot · 2015-04-06T01:40:41Z

Evaluated for origin up to 327c1ca

Merged by openshift-bot

…service-catalog/' changes from 06b897d198..7011d9e816 7011d9e816 origin build: add origin tooling f6eac6e Merge branch 'pr/1322' 6fb9fe8 Drop TPR storage support d337ec4 Moving from global api.Scheme to local Scheme (openshift#1297) a2a9fcc Add referential integrity check on ServiceBroker for Service/Plan (openshift#1317) 1563a74 Revert "Update dependencies to Kubernetes 1.7.6" (openshift#1316) 70e546b Fix json tags for parameters fields (openshift#1312) dcde551 Update to Kubernetes 1.7.6 (openshift#1262) 48e1e53 Add spec.serviceBrokerName field to plan (openshift#1307) 2c43744 add unit tests specifically for resolveReferences (openshift#1314) 6409e2f Resolve instance refs in ReconcileServiceInstance (openshift#1305) bee6afe Fix http verbs supported by servicebrokers/status (openshift#1294) 54199f8 Update walkthrough and correct use of secrets in parameters (openshift#1308) d00f2e3 Add note advising users on content of contrib/pkg (openshift#1277) 66f72b4 v0.0.22 updates (openshift#1306) 1e52673 use canary images when developing (openshift#1260) b26491e Fix HTTP verbs supported by serviceinstances/status (openshift#1302) 44ff690 Fix HTTP verbs supported by serviceinstancecredentials/status (openshift#1304) bbd4d05 Correct JSON tags in v1alpha1 fields (openshift#1301) 766311e Add missing JSON tags (openshift#1295) 3c672ba openshift#1278 - Flaky TestBasicFlowsWithOriginatingIdentity (openshift#1281) 904c236 Add warning to Parameters field doc about sensitive information (openshift#1287) 0c0035c Store in-progress and external properties in instance and binding status. (openshift#1250) 6ab6492 add instance orphan mitigation (openshift#1248) d9d0ea8 Make build of user-broker dependent upon files in contrib/pkg/broker (openshift#1282) 5c99c28 Updated bin/e2e.test to depend on all source (openshift#1280) 454645e Implement changes to k8s naming of ServiceClass and ServicePlan (openshift#1249) 1c81228 remove redundant 'old' validation in UPDATE (openshift#1269) 9c29cfe Wait for test-broker Service endpoint to be available (openshift#1270) 8663c0a Add unstructured serialization test (openshift#1263) 957477f Merge branch 'pr/1274' 1de013b fix http error nil dereference (openshift#1273) 36ba252 Fix race condition in admission controllers that use ServicePlan (openshift#1272) e3c1e86 Remove fmt.Println statements from serialization test 94f8f63 Make controller-manager health check less chatty in logs (openshift#1267) bd70dd4 Move pkg/brokerapi to contrib/pkg/brokerapi (openshift#1255) a38209c openshift#1149 - block concurrent updates to ServiceInstance and ServiceInstanceCredential (openshift#1213) 14dda52 Follow on work from 1252 (openshift#1264) 776fce1 docs/install-1.7.md: clarify that RBAC is optional (openshift#1245) 9064bf3 Add Spec to ServiceClass and ServicePlan (openshift#1252) 277abcd Add option to helm charts for enabling OriginatingIdentity feature (openshift#1251) c9a19c8 Clarify ready condition and event reasons when deprovision is blocked by existing ServiceInstanceCredentials (openshift#1258) d911a5e Add missing test for ServicePlans (openshift#1257) e7cc973 Remove (unused) test dependency on pkg/brokerapi/fake (openshift#1253) 010d6e1 Merge branch 'pr/1240' 170aab5 split plans off of service classes (openshift#1106) a3c6fc7 Chart updates for 0.0.21 (openshift#1244) b55c94e Remove dependency on pkg/brokerapi REVERT: 06b897d198 origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 7011d9e81649fb3e3f563375b69a9b2f79916b9a

smarterclayton force-pushed the status branch from fe57b91 to e1eeece Compare March 16, 2015 04:16

smarterclayton mentioned this pull request Mar 16, 2015

Output build dependencies of a specific image repository #1229

Merged

smarterclayton force-pushed the status branch 9 times, most recently from c4b22af to c1c37da Compare March 30, 2015 18:28

smarterclayton changed the title ~~WIP - Allow graphs of resources to be loaded~~ Implement osc status. Mar 30, 2015

smarterclayton changed the title ~~Implement osc status.~~ Implement osc status Mar 30, 2015

smarterclayton force-pushed the status branch from c1c37da to e58b592 Compare March 30, 2015 18:30

jwforres reviewed Mar 30, 2015
View reviewed changes

smarterclayton force-pushed the status branch from e58b592 to 11c574a Compare March 30, 2015 21:03

jwforres reviewed Mar 30, 2015
View reviewed changes

pkg/api/graph/deployment.go Outdated

Copy link

Member

jwforres Mar 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to match whatever you call ImageDeploymentFlow

smarterclayton force-pushed the status branch from 11c574a to c997490 Compare March 30, 2015 21:12

jwforres reviewed Mar 30, 2015
View reviewed changes

smarterclayton force-pushed the status branch from c997490 to d714abf Compare March 30, 2015 21:30

jwforres reviewed Mar 30, 2015
View reviewed changes

fabianofranz reviewed Mar 31, 2015
View reviewed changes

smarterclayton force-pushed the status branch from d714abf to 4a36991 Compare March 31, 2015 17:42

fabianofranz reviewed Mar 31, 2015
View reviewed changes

smarterclayton force-pushed the status branch from 4a36991 to bb35304 Compare March 31, 2015 17:54

fabianofranz reviewed Mar 31, 2015
View reviewed changes

smarterclayton force-pushed the status branch from bb35304 to 9941ca8 Compare March 31, 2015 23:33

smarterclayton force-pushed the status branch from 9941ca8 to 25b3626 Compare April 1, 2015 21:27

bump(github.com/gonum/graph):f6ac2b0f80f5a28ee70af78ce415393b37bcd6c1

9d474f5

smarterclayton force-pushed the status branch 2 times, most recently from 74d6e88 to e6c2441 Compare April 4, 2015 21:40

smarterclayton added 2 commits April 5, 2015 21:36

Implement an osc status command that groups resources by their rela…

94df0e0

…tionships

UPSTREAM: Do not log errors where the event already exists

327c1ca

smarterclayton force-pushed the status branch from e6c2441 to 327c1ca Compare April 6, 2015 01:36

openshift-bot pushed a commit that referenced this pull request Apr 6, 2015

Merge pull request #1314 from smarterclayton/status

e2ad955

Merged by openshift-bot

openshift-bot merged commit e2ad955 into openshift:master Apr 6, 2015

smarterclayton added the enhancement label Apr 8, 2015

smarterclayton deleted the status branch May 18, 2015 02:16

jpeeler pushed a commit to jpeeler/origin that referenced this pull request Feb 1, 2018

add unit tests specifically for resolveReferences (openshift#1314)

2c43744

Implement osc status #1314

Implement osc status #1314

Uh oh!

Conversation

smarterclayton commented Mar 16, 2015

Uh oh!

smarterclayton commented Mar 30, 2015

Uh oh!

smarterclayton commented Mar 30, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jwforres commented Apr 1, 2015

Uh oh!

jwforres commented Apr 1, 2015

Uh oh!

jwforres commented Apr 1, 2015

Uh oh!

jwforres commented Apr 1, 2015

Uh oh!

smarterclayton commented Apr 1, 2015

Uh oh!

smarterclayton commented Apr 1, 2015

Uh oh!

openshift-bot commented Apr 1, 2015

Uh oh!

smarterclayton commented Apr 2, 2015

Uh oh!

openshift-bot commented Apr 2, 2015

Uh oh!

openshift-bot commented Apr 2, 2015

Uh oh!

openshift-bot commented Apr 6, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Implement `osc status` #1314

Implement `osc status` #1314