create the buildconfig before creating the first imagerepo

[bparees]

hopefully fixes #1158

[bparees]

@ironcladlou ptal. i'm not certain that just watching for the imagerepo create event is sufficient (is it possible that even though the test code has seen the event, it hasn't been delivered to the imagechange controller yet?)

[ironcladlou]

Hrm. Yeah, if your actual precondition is "wait for the imageChangeController to consume the initial image event," then just knowing your orthogonal watch received the event isn't enough.

[bparees]

@ironcladlou take 2.
@soltysh fyi.
[test]

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1249/)

[ironcladlou]

+1, I think this will be stable

[soltysh]

I'd copy here, since you already have the updatedConfig object check for the LastTriggeredImageID:

if updatedConfig.Triggers[0].ImageChange.LastTriggeredImageID != "ref-2" {
    t.Errorf("Expected imageID ref-1, got %s", updatedConfig.Triggers[0].ImageChange.LastTriggeredImageID)
}

[bparees]

as discussed on irc, the check is there for both buildconfigs. (ref-1 and ref-2)

[soltysh]

@bparees good job, I was somewhere close to what you did. Hopefully that will save us from those nasty random failures.

[bparees]

[merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1128/) (Image: devenv-fedora_989)

[openshift-bot]

Evaluated for origin up to 11f85cf