add namespace to internal route keys #1213
Conversation
|
[test] |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1237/) |
pweil-
force-pushed
the
router-namespace-serviceunits
branch
from
372e6b5 to
7426068
Compare
|
Rebase |
pweil-
force-pushed
the
router-namespace-serviceunits
branch
from
7426068 to
208638a
Compare
|
re [test] |
plugins/router/template/plugin.go
Outdated
There was a problem hiding this comment.
Use "%s/%s" instead to match our other conventions
There was a problem hiding this comment.
No problem. Since the key is also used inside the template as part of the name for the backend I will also include a method to provide a template safe version. I need this for path based routing anyway (working on it today) so I'm glad it came up.
pweil-
force-pushed
the
router-namespace-serviceunits
branch
2 times, most recently
from
afb821a to
4dc1e51
Compare
pweil-
force-pushed
the
router-namespace-serviceunits
branch
from
4dc1e51 to
56bc688
Compare
|
Are |
|
Yeah, they're good to go:
http://cbonte.github.io/haproxy-dconv/configuration-1.5.html#4 |
|
and also, damn, I realize now that I just lost an opportunity for an underscore troll. |
|
LGTM [merge] |
|
You did. Maybe next_time ----- Original Message -----
|
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1113/) (Image: devenv-fedora_972) |
|
Evaluated for origin up to 56bc688 |
|
Super late to this party, but this LGTM. On Wed, Mar 4, 2015 at 5:31 PM, OpenShift Bot [email protected]
|
…service-catalog/' changes from 06b897d198..7011d9e816 7011d9e816 origin build: add origin tooling f6eac6e Merge branch 'pr/1322' 6fb9fe8 Drop TPR storage support d337ec4 Moving from global api.Scheme to local Scheme (openshift#1297) a2a9fcc Add referential integrity check on ServiceBroker for Service/Plan (openshift#1317) 1563a74 Revert "Update dependencies to Kubernetes 1.7.6" (openshift#1316) 70e546b Fix json tags for parameters fields (openshift#1312) dcde551 Update to Kubernetes 1.7.6 (openshift#1262) 48e1e53 Add spec.serviceBrokerName field to plan (openshift#1307) 2c43744 add unit tests specifically for resolveReferences (openshift#1314) 6409e2f Resolve instance refs in ReconcileServiceInstance (openshift#1305) bee6afe Fix http verbs supported by servicebrokers/status (openshift#1294) 54199f8 Update walkthrough and correct use of secrets in parameters (openshift#1308) d00f2e3 Add note advising users on content of contrib/pkg (openshift#1277) 66f72b4 v0.0.22 updates (openshift#1306) 1e52673 use canary images when developing (openshift#1260) b26491e Fix HTTP verbs supported by serviceinstances/status (openshift#1302) 44ff690 Fix HTTP verbs supported by serviceinstancecredentials/status (openshift#1304) bbd4d05 Correct JSON tags in v1alpha1 fields (openshift#1301) 766311e Add missing JSON tags (openshift#1295) 3c672ba openshift#1278 - Flaky TestBasicFlowsWithOriginatingIdentity (openshift#1281) 904c236 Add warning to Parameters field doc about sensitive information (openshift#1287) 0c0035c Store in-progress and external properties in instance and binding status. (openshift#1250) 6ab6492 add instance orphan mitigation (openshift#1248) d9d0ea8 Make build of user-broker dependent upon files in contrib/pkg/broker (openshift#1282) 5c99c28 Updated bin/e2e.test to depend on all source (openshift#1280) 454645e Implement changes to k8s naming of ServiceClass and ServicePlan (openshift#1249) 1c81228 remove redundant 'old' validation in UPDATE (openshift#1269) 9c29cfe Wait for test-broker Service endpoint to be available (openshift#1270) 8663c0a Add unstructured serialization test (openshift#1263) 957477f Merge branch 'pr/1274' 1de013b fix http error nil dereference (openshift#1273) 36ba252 Fix race condition in admission controllers that use ServicePlan (openshift#1272) e3c1e86 Remove fmt.Println statements from serialization test 94f8f63 Make controller-manager health check less chatty in logs (openshift#1267) bd70dd4 Move pkg/brokerapi to contrib/pkg/brokerapi (openshift#1255) a38209c openshift#1149 - block concurrent updates to ServiceInstance and ServiceInstanceCredential (openshift#1213) 14dda52 Follow on work from 1252 (openshift#1264) 776fce1 docs/install-1.7.md: clarify that RBAC is optional (openshift#1245) 9064bf3 Add Spec to ServiceClass and ServicePlan (openshift#1252) 277abcd Add option to helm charts for enabling OriginatingIdentity feature (openshift#1251) c9a19c8 Clarify ready condition and event reasons when deprovision is blocked by existing ServiceInstanceCredentials (openshift#1258) d911a5e Add missing test for ServicePlans (openshift#1257) e7cc973 Remove (unused) test dependency on pkg/brokerapi/fake (openshift#1253) 010d6e1 Merge branch 'pr/1240' 170aab5 split plans off of service classes (openshift#1106) a3c6fc7 Chart updates for 0.0.21 (openshift#1244) b55c94e Remove dependency on pkg/brokerapi REVERT: 06b897d198 origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 7011d9e81649fb3e3f563375b69a9b2f79916b9a
…iceInstanceCredential (openshift#1213) * Block operations on Instance and Binding when Controller is already performing operation * code review feedback
4 participants
Change internal key for service unit from Route.Name to Namespace-Name. Removes TODO about namespaces in the route key.
@pmorie PTAL