Bug 1762409: Fix memory dereference bug in eventrouter by openshift-cherrypick-robot · Pull Request #1768 · openshift/origin-aggregated-logging

openshift-cherrypick-robot · 2019-10-16T18:25:30Z

This is an automated cherry-pick of #1766

/assign richm

https://bugzilla.redhat.com/show_bug.cgi?id=1756920 This tries to keep the functionality the same in 4.x as it was in 3.x. In 3.x, you had to: - deploy the eventrouter with a pod name like "logging-eventrouter-*" - deploy the eventrouter in the default namespace - set `TRANSFORM_EVENTS=true` - set `MERGE_JSON_LOG=true` (which was the default in 3.x) In 4.x, the pod name changes to "eventrouter-*" to follow the convention of our other logging pods. The eventrouter defaults to running in "openshift-logging" - it doesn't really matter, as long as it is running in an "infra" namespace. This change also enables `MERGE_JSON_LOG=true` for eventrouter pods. The biggest problem is that you have to set the cluster to unmanaged in order to set `TRANSFORM_EVENTS=true`. We could workaround that by making `TRANSFORM_EVENTS=true` the default value. That would cause every kubernetes record to be checked to see if it looks like and event, and process it as such if it matches. I'm not sure what the performance implications would be. Also ports eventrouter test to 4.x Also adds a test for eventrouter Info type support update eventrouter to pick up fix for Bug 1701495

openshift-ci-robot · 2019-10-16T18:25:31Z

@openshift-cherrypick-robot: An error was encountered searching for bug 1756920 on the Bugzilla server at https://bugzilla.redhat.com:

did not get one bug, but 0: {[]}
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.2] Bug 1756920: fluentd pods do not process kubernetes events

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-10-16T18:26:14Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1762409 - Eventrouter pod in CrashLoopBackOff status: "runtime error: invalid memory address or nil pointer dereference"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-10-16T18:26:24Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1762409, which is invalid:

expected dependent Bugzilla bug 1701495 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1762409: Eventrouter pod in CrashLoopBackOff status: "runtime error: invalid memory address or nil pointer dereference"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richm · 2019-10-17T17:04:49Z

/retest

richm · 2019-10-17T18:12:22Z

aws flake
/retest

richm · 2019-10-17T20:47:14Z

strange flake with api.ci registry? all of the other fluentd pods were fine

fluentd-pcrb8                                   0/1     ImagePullBackOff   0          14m

/retest

richm · 2019-10-17T21:44:58Z

aws flake
/retest

richm · 2019-10-18T16:46:01Z

level=fatal msg="failed to initialize the cluster: Cluster operator monitoring is still updating"

flake?
/retest

richm · 2019-10-30T13:18:21Z

/bugzilla refresh

openshift-ci-robot · 2019-10-30T13:18:24Z

@richm: This pull request references Bugzilla bug 1762409, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richm · 2019-10-30T13:38:28Z

/bugzilla refresh

openshift-ci-robot · 2019-10-30T13:38:33Z

@richm: This pull request references Bugzilla bug 1762409, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richm · 2019-10-30T13:43:08Z

/lgtm

openshift-ci-robot · 2019-10-30T13:43:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, richm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [richm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

richm · 2019-10-30T15:27:25Z

NOTE to openshift patch manager/cherry-pick approver - this doesn't really fix Bug 1762409: Eventrouter pod in CrashLoopBackOff status: "runtime erro - the real fix for that bug was done in origin/eventrouter, fixed in the openshift-eventrouter rpm, and built into the eventrouter image. This PR is primarily for adding an eventrouter test for that BZ. Also, this BZ enhances the eventrouter test which blocks other PRs/BZs which depend on that test.

crawford · 2019-11-01T22:35:00Z

/retitle Bug 1762409: Fix memory dereference bug in eventrouter

crawford · 2019-11-01T22:39:25Z

Looks like @openshift-ci-robot already took off for the weekend.

openshift-bot · 2019-11-02T00:21:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-11-02T01:53:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-11-02T03:37:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2019-11-02T05:18:21Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1762409 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1762409: Fix memory dereference bug in eventrouter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richm · 2019-11-04T01:13:31Z

/cherrypick release-4.1

openshift-cherrypick-robot · 2019-11-04T01:13:47Z

@richm: new pull request created: #1777

Details

In response to this:

/cherrypick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned richm Oct 16, 2019

openshift-cherrypick-robot mentioned this pull request Oct 16, 2019

Bug 1756920: fluentd pods do not process kubernetes events #1766

Merged

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2019

openshift-ci-robot requested review from lukas-vlcek and richm October 16, 2019 18:25

richm changed the title ~~[release-4.2] Bug 1756920: fluentd pods do not process kubernetes events~~ Bug 1762409 - Eventrouter pod in CrashLoopBackOff status: "runtime error: invalid memory address or nil pointer dereference" Oct 16, 2019

richm changed the title ~~Bug 1762409 - Eventrouter pod in CrashLoopBackOff status: "runtime error: invalid memory address or nil pointer dereference"~~ Bug 1762409: Eventrouter pod in CrashLoopBackOff status: "runtime error: invalid memory address or nil pointer dereference" Oct 16, 2019

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 16, 2019

richm added kind/bug Categorizes issue or PR as related to a bug. release/4.2 and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 16, 2019

richm mentioned this pull request Oct 18, 2019

Bug 1756920: fluentd pods doesn't process kubernetes events #1770

Merged

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 30, 2019

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 30, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019

crawford changed the title ~~Bug 1762409: Eventrouter pod in CrashLoopBackOff status: "runtime error: invalid memory address or nil pointer dereference"~~ Bug 1762409: Fix memory dereference bug in eventrouter Nov 1, 2019

crawford added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 1, 2019

openshift-merge-robot merged commit af20a35 into openshift:release-4.2 Nov 2, 2019

openshift-cherrypick-robot mentioned this pull request Nov 4, 2019

Bug 1764312: Eventrouter pod in CrashLoopBackOff status: "runtime error: invalid memory address or nil pointer dereference" #1777

Closed

Conversation

openshift-cherrypick-robot commented Oct 16, 2019

Uh oh!

openshift-ci-robot commented Oct 16, 2019

Uh oh!

openshift-ci-robot commented Oct 16, 2019

Uh oh!

openshift-ci-robot commented Oct 16, 2019

Uh oh!

richm commented Oct 17, 2019

Uh oh!

richm commented Oct 17, 2019

Uh oh!

richm commented Oct 17, 2019

Uh oh!

richm commented Oct 17, 2019

Uh oh!

richm commented Oct 18, 2019

Uh oh!

richm commented Oct 30, 2019

Uh oh!

openshift-ci-robot commented Oct 30, 2019

Uh oh!

richm commented Oct 30, 2019

Uh oh!

openshift-ci-robot commented Oct 30, 2019

Uh oh!

richm commented Oct 30, 2019

Uh oh!

openshift-ci-robot commented Oct 30, 2019

Uh oh!

richm commented Oct 30, 2019

Uh oh!

crawford commented Nov 1, 2019

Uh oh!

crawford commented Nov 1, 2019

Uh oh!

openshift-bot commented Nov 2, 2019

Uh oh!

openshift-bot commented Nov 2, 2019

Uh oh!

openshift-bot commented Nov 2, 2019

Uh oh!

openshift-ci-robot commented Nov 2, 2019

Uh oh!

richm commented Nov 4, 2019

Uh oh!

openshift-cherrypick-robot commented Nov 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants