Bug 1764312: Eventrouter pod in CrashLoopBackOff status: "runtime error: invalid memory address or nil pointer dereference" by openshift-cherrypick-robot · Pull Request #1777 · openshift/origin-aggregated-logging

openshift-cherrypick-robot · 2019-11-04T01:13:47Z

This is an automated cherry-pick of #1768

/assign richm

https://bugzilla.redhat.com/show_bug.cgi?id=1756920 This tries to keep the functionality the same in 4.x as it was in 3.x. In 3.x, you had to: - deploy the eventrouter with a pod name like "logging-eventrouter-*" - deploy the eventrouter in the default namespace - set `TRANSFORM_EVENTS=true` - set `MERGE_JSON_LOG=true` (which was the default in 3.x) In 4.x, the pod name changes to "eventrouter-*" to follow the convention of our other logging pods. The eventrouter defaults to running in "openshift-logging" - it doesn't really matter, as long as it is running in an "infra" namespace. This change also enables `MERGE_JSON_LOG=true` for eventrouter pods. The biggest problem is that you have to set the cluster to unmanaged in order to set `TRANSFORM_EVENTS=true`. We could workaround that by making `TRANSFORM_EVENTS=true` the default value. That would cause every kubernetes record to be checked to see if it looks like and event, and process it as such if it matches. I'm not sure what the performance implications would be. Also ports eventrouter test to 4.x Also adds a test for eventrouter Info type support update eventrouter to pick up fix for Bug 1701495

openshift-ci-robot · 2019-11-04T01:13:49Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1762409, which is invalid:

expected the bug to target the "4.1.z" release, but it targets "4.2.z" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.1] Bug 1762409: Fix memory dereference bug in eventrouter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-11-04T01:20:57Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1764312, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
expected dependent Bugzilla bug 1762409 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1764312: Eventrouter pod in CrashLoopBackOff status: "runtime error: invalid memory address or nil pointer dereference"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richm · 2019-11-04T01:21:31Z

NOTE to openshift patch manager/cherry-pick approver - this doesn't really fix Bug 1762409: Eventrouter pod in CrashLoopBackOff status: "runtime erro - the real fix for that bug was done in origin/eventrouter, fixed in the openshift-eventrouter rpm, and built into the eventrouter image. This PR is primarily for adding an eventrouter test for that BZ. Also, this BZ enhances the eventrouter test which blocks other PRs/BZs which depend on that test.

richm · 2019-11-04T01:21:36Z

/lgtm

openshift-ci-robot · 2019-11-04T01:21:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, richm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [richm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

richm · 2019-11-04T14:58:58Z

/test full-integ-aws

richm · 2019-11-04T16:46:01Z

/test full-integ-aws

richm · 2019-11-05T15:33:01Z

/test full-integ-aws

openshift-bot · 2019-11-08T00:06:50Z

/retest