Bug 1756920: fluentd pods doesn't process kubernetes events by richm · Pull Request #1770 · openshift/origin-aggregated-logging

richm · 2019-10-18T00:34:06Z

https://bugzilla.redhat.com/show_bug.cgi?id=1756920
Use the new feature of the viaq plugin to only do the
event transform for records with a specific tag.

https://bugzilla.redhat.com/show_bug.cgi?id=1756920 Use the new feature of the viaq plugin to only do the event transform for records with a specific tag.

openshift-ci-robot · 2019-10-18T00:34:07Z

@richm: An error was encountered searching for bug 1756920 on the Bugzilla server at https://bugzilla.redhat.com:

did not get one bug, but 0: {[]}
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1756920: fluentd pods doesn't process kubernetes events

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richm · 2019-10-18T00:35:42Z

/bugzilla refresh

openshift-ci-robot · 2019-10-18T00:35:43Z

@richm: An error was encountered searching for bug 1756920 on the Bugzilla server at https://bugzilla.redhat.com:

did not get one bug, but 0: {[]}
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nhosoi · 2019-10-18T01:02:32Z

/lgtm

openshift-ci-robot · 2019-10-18T01:02:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nhosoi, richm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [nhosoi,richm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

richm · 2019-10-18T02:44:25Z

multi-tenancy flake
/retest

jcantrill · 2019-10-18T02:59:57Z

fluentd/configs.d/openshift/filter-viaq-data-model.conf

    type k8s_journal
    remove_keys "#{ENV['K8S_FILTER_REMOVE_KEYS'] || 'log,stream,MESSAGE,_SOURCE_REALTIME_TIMESTAMP,__REALTIME_TIMESTAMP,CONTAINER_ID,CONTAINER_ID_FULL,CONTAINER_NAME,PRIORITY,_BOOT_ID,_CAP_EFFECTIVE,_CMDLINE,_COMM,_EXE,_GID,_HOSTNAME,_MACHINE_ID,_PID,_SELINUX_CONTEXT,_SYSTEMD_CGROUP,_SYSTEMD_SLICE,_SYSTEMD_UNIT,_TRANSPORT,_UID,_AUDIT_LOGINUID,_AUDIT_SESSION,_SYSTEMD_OWNER_UID,_SYSTEMD_SESSION,_SYSTEMD_USER_UNIT,CODE_FILE,CODE_FUNCTION,CODE_LINE,ERRNO,MESSAGE_ID,RESULT,UNIT,_KERNEL_DEVICE,_KERNEL_SUBSYSTEM,_UDEV_SYSNAME,_UDEV_DEVNODE,_UDEV_DEVLINK,SYSLOG_FACILITY,SYSLOG_IDENTIFIER,SYSLOG_PID'}"
  </formatter>
+  <formatter>


We will need to pull this into the CLO when openshift/cluster-logging-operator#231 merges as it intentionally pulls all these configs into the conf generation instead of including these files.

openshift-ci-robot · 2019-10-18T04:12:45Z

@richm: An error was encountered searching for bug 1756920 on the Bugzilla server at https://bugzilla.redhat.com:

did not get one bug, but 0: {[]}
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1756920: fluentd pods doesn't process kubernetes events

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richm · 2019-10-18T16:40:42Z

/cherrypick release-4.2

openshift-cherrypick-robot · 2019-10-18T16:40:53Z

@richm: #1770 failed to apply on top of branch "release-4.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	fluentd/configs.d/openshift/filter-viaq-data-model.conf
M	test/eventrouter.sh
Falling back to patching base and 3-way merge...
Auto-merging test/eventrouter.sh
CONFLICT (content): Merge conflict in test/eventrouter.sh
Auto-merging fluentd/configs.d/openshift/filter-viaq-data-model.conf
Patch failed at 0001 Bug 1756920: fluentd pods doesn't process kubernetes events

Details

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richm · 2019-10-18T16:46:20Z

can't cherrypick until #1768 merges

richm · 2019-10-30T14:59:15Z

/cherrypick release-4.2

openshift-cherrypick-robot · 2019-10-30T14:59:28Z

@richm: #1770 failed to apply on top of branch "release-4.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	fluentd/configs.d/openshift/filter-viaq-data-model.conf
M	test/eventrouter.sh
Falling back to patching base and 3-way merge...
Auto-merging test/eventrouter.sh
CONFLICT (content): Merge conflict in test/eventrouter.sh
Auto-merging fluentd/configs.d/openshift/filter-viaq-data-model.conf
Patch failed at 0001 Bug 1756920: fluentd pods doesn't process kubernetes events

Details

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richm · 2019-11-04T01:14:54Z

/cherrypick release-4.2

openshift-cherrypick-robot · 2019-11-04T01:15:01Z

@richm: new pull request created: #1778

Details

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bug 1756920: fluentd pods doesn't process kubernetes events

c7272dc

https://bugzilla.redhat.com/show_bug.cgi?id=1756920 Use the new feature of the viaq plugin to only do the event transform for records with a specific tag.

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 18, 2019

openshift-ci-robot requested review from jcantrill and lukas-vlcek October 18, 2019 00:34

richm added component/fluentd kind/bug Categorizes issue or PR as related to a bug. release/4.3 labels Oct 18, 2019

richm requested a review from nhosoi October 18, 2019 00:35

openshift-ci-robot assigned nhosoi Oct 18, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2019

jcantrill reviewed Oct 18, 2019

View reviewed changes

openshift-merge-robot merged commit a137078 into openshift:master Oct 18, 2019

richm deleted the bz1756920-fluentd-does-not-process-kubernetes-events branch October 18, 2019 14:21

openshift-cherrypick-robot mentioned this pull request Nov 4, 2019

Bug 1763282: fluentd pods doesn't process kubernetes events #1778

Merged

Conversation

richm commented Oct 18, 2019

Uh oh!

openshift-ci-robot commented Oct 18, 2019

Uh oh!

richm commented Oct 18, 2019

Uh oh!

openshift-ci-robot commented Oct 18, 2019

Uh oh!

nhosoi commented Oct 18, 2019

Uh oh!

openshift-ci-robot commented Oct 18, 2019

Uh oh!

richm commented Oct 18, 2019

Uh oh!

jcantrill Oct 18, 2019

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Oct 18, 2019

Uh oh!

richm commented Oct 18, 2019

Uh oh!

openshift-cherrypick-robot commented Oct 18, 2019

Uh oh!

richm commented Oct 18, 2019

Uh oh!

richm commented Oct 30, 2019

Uh oh!

openshift-cherrypick-robot commented Oct 30, 2019

Uh oh!

richm commented Nov 4, 2019

Uh oh!

openshift-cherrypick-robot commented Nov 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants