Skip to content

Comments

Refactor get_coredns_config (NE-2449): Use DynamicClient & testify/suite#151

Open
bentito wants to merge 1 commit intoopenshift:mainfrom
bentito:refactor/NE-2449-coredns-dynamic-client
Open

Refactor get_coredns_config (NE-2449): Use DynamicClient & testify/suite#151
bentito wants to merge 1 commit intoopenshift:mainfrom
bentito:refactor/NE-2449-coredns-dynamic-client

Conversation

@bentito
Copy link

@bentito bentito commented Feb 19, 2026

This PR refactors the get_coredns_config tool introduced in #131 to align with the patterns established in #144.

Changes:

  • Dynamic Client: Switched from controller-runtime client to DynamicClient for consistency with inspect_route.
  • Test Suite: Migrated tests to testify/suite for better grouping and setup logic.
  • New Test Suite: Created pkg/toolsets/netedge/suite_test.go to house the shared NetEdgeTestSuite.

This addresses feedback from @matzew regarding test grouping and client usage.

Related PRs:

@openshift-ci openshift-ci bot requested review from Cali0707 and matzew February 19, 2026 19:35
@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bentito
Once this PR has been reviewed and has the lgtm label, please assign kaustubh-pande for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

@bentito: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

bentito added a commit to bentito/openshift-mcp-server that referenced this pull request Feb 19, 2026
This refactors query_prometheus to use DynamicClient and NetEdgeTestSuite, aligning with PR openshift#151 and PR openshift#144. Moves query_prometheus to the netedge package to share test infrastructure.

Signed-off-by: bentito <btofel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant