NE-2449: add netedge tool and get_coredns_config

[bentito]

This PR introduces the netedge toolset for Network Ingress & DNS troubleshooting, starting with a specialized tool to inspect CoreDNS configuration.

Changes:

• New Toolset: Created pkg/toolsets/netedge to house network edge diagnostic tools.
• New Tool (get_coredns_config):
  • Implements a read-only tool to retrieve the active CoreDNS configuration.
  • Specifically targets the dns-default ConfigMap in the openshift-dns namespace to extract the Corefile.
  • Utilizes a controller-runtime client for Kubernetes interactions, setting a pattern for future tools in this set.
  • Configured with OpenWorldHint: true to allow broad usage in troubleshooting contexts.
• Testing: Added unit tests using controller-runtime's fake client to verify handler logic (ConfigMap retrieval, error handling for missing keys/resources) without requiring a live cluster.
• Dependencies: Updated vendor/ to include controller-runtime/pkg/client/fake and related packages to support the new testing pattern.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bentito
Once this PR has been reviewed and has the lgtm label, please assign manusa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@bentito: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	309061c	link	false	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@bentito: This pull request references NE-2449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR introduces the netedge toolset for Network Ingress & DNS troubleshooting, starting with a specialized tool to inspect CoreDNS configuration.

Changes:

• New Toolset: Created pkg/toolsets/netedge to house network edge diagnostic tools.
• New Tool (get_coredns_config):
  • Implements a read-only tool to retrieve the active CoreDNS configuration.
  • Specifically targets the dns-default ConfigMap in the openshift-dns namespace to extract the Corefile.
  • Utilizes a controller-runtime client for Kubernetes interactions, setting a pattern for future tools in this set.
  • Configured with OpenWorldHint: true to allow broad usage in troubleshooting contexts.
• Testing: Added unit tests using controller-runtime's fake client to verify handler logic (ConfigMap retrieval, error handling for missing keys/resources) without requiring a live cluster.
• Dependencies: Updated vendor/ to include controller-runtime/pkg/client/fake and related packages to support the new testing pattern.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bentito]

/jira-refresh

[bentito]

/jira-refresh

[matzew]

I guess this is anyways just OCP - hence the hardcoded ns value is ok?

[matzew]

Could we group the tests to use the testify/suite pattern, as mentioned on the AGENTS.md file?

e.g. like

  type CoreDNSSuite struct {
      suite.Suite
  }

and have tests registered on that CoreDNSSuite ?

[matzew]

I guess this conflicts with your "prometheus" PR (e.g. pkg/toolsets/netedge/toolset.go 😅 ) - so do you want this in before the other? just wondering