Edits to builds file #587
Merged
Edits to builds file #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev_guide/builds.adoc
Outdated
There was a problem hiding this comment.
Probably want to mark-up ruby-sample-build.
bfallonf
force-pushed
the
builds_file
branch
2 times, most recently
from
981c3b2 to
3fdb6d2
Compare
Author
|
@tnguyen-rh Thanks for the peer review. Comments/suggestions implemented. If nothing else, should be ok to merge. |
dev_guide/builds.adoc
Outdated
Contributor
There was a problem hiding this comment.
Looks like these three lost the space after the -, so they're not rendering as a list.
Contributor
|
@bfallonf Comments inline. |
Author
|
@adellape Comments addressed. |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third try at editing the procedures in the dev_guide/builds file. The first being #443 and the second being #496 . Both closed.
Not sure if tech review is needed, as the devs have had a play with this file, so maybe just peer review?
@tpoitras @tnguyen-rh @adellape ^