-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[do not merge] Edits procedures in builds file #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soltysh If Kubernetes provides the secret, why are we creating one in the next step? Would it more accurate to say something like "Kubernetes has the ability to utilize secret..." then we go on to create the secret for Kubernetes to utilize?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, by provides I've meant about the ability to create ones.
|
@adellape True. Similar, but not exact. Once the other merges I'll get that info in here and go through this one again. I think most (all?) of my questions above still stand. |
|
@bfallonf Yea, my comment here was just an FYI that this would probably conflict. Merged 431, so this needs a rebase. |
|
@bfallonf sorry, I was out yesterday, will review this today. |
|
Seems #444 has created many more conflicts. I'll get to this once that's ironed out. |
|
@bfallonf Should be safe to rebase now. |
|
Might have to close this one. The builds file has been through too many changes to make this workable. The work from this PR is now in #496 |
@soltysh This PR is in response to your PR: #339
I have some questions, though it might be easier to ask them in the file as they're about specific parts that would be hard to reference here...
Thanks!