[do not merge] Edits to procedures in the dev_guide/builds file #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
i'm staying out of these files until the dust settles. but please do let me know when that has happened :) |
Contributor
There was a problem hiding this comment.
This won't actually render/do anything.
Author
|
@bfallonf sorry, that wasn't intended 😸 |
adellape
changed the title
Merged
Author
|
Edits continued here: #587 |
sbeskin-redhat
pushed a commit
to sbeskin-redhat/openshift-docs
that referenced
this pull request
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an edits to the procedures in the dev_guide/buildes file, originally in PR #443 , but the conflicts got too much (I'll have to close that one). @soltysh I can see you incorporated your feedback from my questions from that PR into your edits. Big thanks!
However, this does mean your edits to this file in the #492 might be a bit...conflict-ey. If we're done with the builds file it'd be so great to this PR merged. My original PR was created 11 days ago and I need to stop playing with conflicts here...
@mfojtik @bparees , tagging you guys as well, in case there's any other edits to the builds file I need to be worried about...