-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Edits to self_provisioning file #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Re: 1), the live example in Re: 2), my other PR #331 also happens to update Re: 3) my understanding from trying it out the other day was that it uses an already established template that behaves in the manner described in the original PR. You can view the default template after the master has started up using: |
|
@adellape Thanks! I'll leave the first part to you and your PR. As for question 2, I just updated the command. The rest of your changes in that file (section headings, rewording, etc) can probably go through when/if that PR goes ahead. If not, the rest can go in during another edit. As for the last questions, and after our chat today, I'm not sure if too much is needed, but I went about some minor rewording and threw in your command about checking the default template. @deads2k Please let us know what you think of the changes and if there's anything else need for this doc. |
|
I have good news and bad news. The good news is that the doc looks good for today's code. The bad news is that there will be some changes (hopefully today) around exactly what the defaulting mechanism looks like. I'll come back and add comments once it's been reworked. |
|
openshift/origin#2267 changes behavior in the following ways:
The template substitution variables are still correct and making a custom template still works the same way. |
|
@deads2k If it's no longer written out anywhere, would it be useful to document what an example project template could look like, as a starting point in case someone wants to create a custom one? For example, from looking at the default template yesterday: https://gist.github.com/adellape/2979d03460c928af91d7 |
Very useful. That template looks fine. |
|
just remember to strip the auto-completed stuff. |
|
@deads2k @adellape Thanks for the extra info for this. I've made the changes outlined above, and put in the example template. Although I've taken out the Question: What's the difference between the default template Alex gave above, and the example template given in the templates section of the docs: http://docs.openshift.com/enterprise/latest/dev_guide/templates.html# Seems like it would be a good idea to just link to the templates file... Either way, if what we have here is appropriate, this might be near completion. Thanks, guys! |
|
@bfallonf A template in general can describe all sorts of resources. The example template being shown for this topic is more specifically describing a particular set of resources that can be used by a platform admin to customize the default "new project request" scenario. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove line and remove:
- creationTimestamp
- resoruceVersion
- selfLink
- uid
|
Further edit: @adellape I also put in the changes to the default template information, as discussed on IRC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We create the default template internally, but we never persist it, so you can't view it.
e5889b8 to
28b2113
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about "Templates for New Projects"? Avoids starting off the title with "The".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adellape Good suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe embed link to ../architecture/additional_concepts/authorization.html#roles on "role binding" for context.
|
@adellape Done. Thanks for the suggestions. I went through the entire projects.adoc file too and made sure the formatting was right. If there's nothing else, this should be ok to merge. |
|
Thanks, merging. |
Edits to self_provisioning file
Update doc attributes for 5.1
@deads2k , this is some initial edits to PR #359 .
A few questions though:
projectRequestTemplateparameter in the master config file, but the example file in admin_guide/master_node_configuration doesn't have that parameter anywhere. Does this mean that this is optional? And that the reader has to manually put in the parameter? Or maybe the example file in master_node_configuration is out of date?osadm...Thanks in advance!